Skip to content

Commit 0c94a62

Browse files
add fallback for float16
1 parent ae5b1b5 commit 0c94a62

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pandas/core/base.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1294,7 +1294,12 @@ def factorize(
12941294
else:
12951295
from pandas import Index
12961296

1297-
uniques = Index(uniques, dtype=self.dtype)
1297+
try:
1298+
uniques = Index(uniques, dtype=self.dtype)
1299+
except NotImplementedError:
1300+
# not all dtypes are supported in Index that are allowed for Series
1301+
# e.g. float16 or bytes
1302+
uniques = Index(uniques)
12981303
return codes, uniques
12991304

13001305
_shared_docs["searchsorted"] = """

pandas/tests/test_algos.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def test_factorize_complex(self):
6565
expected_uniques = np.array([(1 + 0j), (2 + 0j), (2 + 1j)], dtype=complex)
6666
tm.assert_numpy_array_equal(uniques, expected_uniques)
6767

68-
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)", strict=False)
6968
def test_factorize(self, index_or_series_obj, sort):
7069
obj = index_or_series_obj
7170
result_codes, result_uniques = obj.factorize(sort=sort)

0 commit comments

Comments
 (0)