TST: Avoid time.sleep in tests

Author: mroeschke

pandas/tests/io/excel/test_style.py

@@ -1,5 +1,4 @@
 import contextlib
-import time
 import uuid
 
 import numpy as np
@@ -324,18 +323,10 @@ def test_styler_to_s3(s3_bucket_public, s3so):
     target_file = f"{uuid.uuid4()}.xlsx"
     df = DataFrame({"x": [1, 2, 3], "y": [2, 4, 6]})
     styler = df.style.set_sticky(axis="index")
-    styler.to_excel(f"s3://{mock_bucket_name}/{target_file}", storage_options=s3so)
-    timeout = 5
-    while True:
-        if target_file in (obj.key for obj in s3_bucket_public.objects.all()):
-            break
-        time.sleep(0.1)
-        timeout -= 0.1
-        assert timeout > 0, "Timed out waiting for file to appear on moto"
-        result = read_excel(
-            f"s3://{mock_bucket_name}/{target_file}", index_col=0, storage_options=s3so
-        )
-        tm.assert_frame_equal(result, df)
+    uri = f"s3://{mock_bucket_name}/{target_file}"
+    styler.to_excel(uri, storage_options=s3so)
+    result = read_excel(uri, index_col=0, storage_options=s3so)
+    tm.assert_frame_equal(result, df)
 
 
 @pytest.mark.parametrize("merge_cells", [True, False, "columns"])

pandas/tests/io/json/test_pandas.py

@@ -7,7 +7,6 @@
 import json
 import os
 import sys
-import time
 import uuid
 
 import numpy as np
@@ -2019,14 +2018,10 @@ def test_to_s3(self, s3_bucket_public, s3so):
         mock_bucket_name = s3_bucket_public.name
         target_file = f"{uuid.uuid4()}.json"
         df = DataFrame({"x": [1, 2, 3], "y": [2, 4, 6]})
-        df.to_json(f"s3://{mock_bucket_name}/{target_file}", storage_options=s3so)
-        timeout = 5
-        while True:
-            if target_file in (obj.key for obj in s3_bucket_public.objects.all()):
-                break
-            time.sleep(0.1)
-            timeout -= 0.1
-            assert timeout > 0, "Timed out waiting for file to appear on moto"
+        uri = f"s3://{mock_bucket_name}/{target_file}"
+        df.to_json(uri, storage_options=s3so)
+        result = read_json(uri, storage_options=s3so)
+        tm.assert_frame_equal(result, df)
 
     def test_json_pandas_nulls(self, nulls_fixture):
         # GH 31615

pandas/tests/io/pytables/test_store.py

@@ -90,7 +90,7 @@ def create_h5_and_return_checksum(tmp_path, track_times):
     checksum_0_tt_true = create_h5_and_return_checksum(tmp_path, track_times=True)
 
     # sleep is necessary to create h5 with different creation time
-    time.sleep(1)
+    time.sleep(0.5)
 
     checksum_1_tt_false = create_h5_and_return_checksum(tmp_path, track_times=False)
     checksum_1_tt_true = create_h5_and_return_checksum(tmp_path, track_times=True)

pandas/tests/io/test_compression.py

@@ -6,7 +6,6 @@
 import sys
 import tarfile
 import textwrap
-import time
 import zipfile
 
 import numpy as np
@@ -186,7 +185,6 @@ def test_gzip_reproducibility_file_name():
     with tm.ensure_clean() as path:
         path = Path(path)
         df.to_csv(path, compression=compression_options)
-        time.sleep(0.1)
         output = path.read_bytes()
         df.to_csv(path, compression=compression_options)
         assert output == path.read_bytes()
@@ -209,7 +207,6 @@ def test_gzip_reproducibility_file_object():
     buffer = io.BytesIO()
     df.to_csv(buffer, compression=compression_options, mode="wb")
     output = buffer.getvalue()
-    time.sleep(0.1)
     buffer = io.BytesIO()
     df.to_csv(buffer, compression=compression_options, mode="wb")
     assert output == buffer.getvalue()