Skip to content

Commit 1e6197c

Browse files
committed
REF: Simplify test_attrs_binary_operations by parameterizing left and right inputs
1 parent 3abc22d commit 1e6197c

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

pandas/tests/generic/test_finalize.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -450,18 +450,14 @@ def test_binops(request, args, annotate, all_binary_operators):
450450
assert result.attrs == {"a": 1}
451451

452452

453-
@pytest.mark.parametrize(
454-
"left, right, attrs",
455-
[
456-
(pd.DataFrame([1]), pd.DataFrame([2]), {"a": 1}),
457-
(pd.Series([1]), pd.Series([2]), {"a": 1}),
458-
(pd.Series([1]), pd.DataFrame([2]), {"a": 1}),
459-
(pd.DataFrame([1]), pd.Series([2]), {"a": 1}),
460-
],
461-
)
462-
def test_attrs_binary_operations(all_binary_operators, left, right, attrs):
453+
@pytest.mark.parametrize("left", [pd.Series, pd.DataFrame])
454+
@pytest.mark.parametrize("right", [pd.Series, pd.DataFrame])
455+
def test_attrs_binary_operations(all_binary_operators, left, right):
463456
# GH 51607
457+
attrs = {"a": 1}
458+
left = left([1])
464459
left.attrs = attrs
460+
right = right([2])
465461
assert all_binary_operators(left, right).attrs == attrs
466462
assert all_binary_operators(right, left).attrs == attrs
467463

0 commit comments

Comments
 (0)