Skip to content

Commit 2258d64

Browse files
committed
Better comments plus always run before-build/before-test on 3.13
1 parent c487998 commit 2258d64

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

.github/workflows/wheels.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,11 @@ jobs:
103103
include:
104104
# 'pip' is the default
105105
- cibw_build_frontend: pip
106-
# TODO: Remove this and installing build deps in cibw_before_build.sh
107-
# after NumPy can be built with a released Cython
106+
# TODO: Remove this plus installing build deps in cibw_before_build.sh
107+
# and test deps in cibw_before_test.sh after pandas can be built with a released NumPy/Cython
108108
- python: ["cp313t", "3.13"]
109109
cibw_build_frontend: 'pip; args: --no-build-isolation'
110+
# TODO: Build free-threaded wheels for Windows
110111
exclude:
111112
- buildplat: [windows-2022, win_amd64]
112113
python: ["cp313t", "3.13"]

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ before-build = "bash {package}/scripts/cibw_before_build.sh"
159159
before-test = "bash {package}/scripts/cibw_before_test.sh"
160160

161161
[tool.cibuildwheel.windows]
162-
before-build = "pip install delvewheel"
162+
before-build = "pip install delvewheel && bash {package}/scripts/cibw_before_build.sh"
163163
repair-wheel-command = "delvewheel repair -w {dest_dir} {wheel}"
164164

165165
[[tool.cibuildwheel.overrides]]

scripts/cibw_before_build.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# TODO: delete along with enabling build isolation by unsetting
2-
# CIBW_BUILD_FRONTEND when scipy is buildable under free-threaded
3-
# python with a released version of cython
4-
FREE_THREADED_BUILD="$(python -c "import sysconfig; print(bool(sysconfig.get_config_var('Py_GIL_DISABLED')))")"
5-
if [[ $FREE_THREADED_BUILD == "True" ]]; then
1+
# TODO: Delete when there's PyPI NumPy/Cython releases the support Python 3.13.
2+
# If free-threading support is not included in those releases, this script will have
3+
# to whether this runs for a free-threaded build instead.
4+
PYTHON_VERSION="$(python -c "import sys; print(f'{sys.version_info.major}{sys.version_info.minor}')")"
5+
if [[ $PYTHON_VERSION == "313" ]]; then
66
python -m pip install -U pip
77
python -m pip install -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy cython
88
python -m pip install ninja meson-python versioneer[toml]

scripts/cibw_before_test.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# TODO: delete along with enabling build isolation by unsetting
2-
# CIBW_BUILD_FRONTEND when scipy is buildable under free-threaded
3-
# python with a released version of cython
4-
FREE_THREADED_BUILD="$(python -c "import sysconfig; print(bool(sysconfig.get_config_var('Py_GIL_DISABLED')))")"
5-
if [[ $FREE_THREADED_BUILD == "True" ]]; then
1+
# TODO: Delete when there's PyPI NumPy/Cython releases the support Python 3.13.
2+
# If free-threading support is not included in those releases, this script will have
3+
# to whether this runs for a free-threaded build instead.
4+
PYTHON_VERSION="$(python -c "import sys; print(f'{sys.version_info.major}{sys.version_info.minor}')")"
5+
if [[ $PYTHON_VERSION == "313" ]]; then
66
python -m pip install -U pip
77
python -m pip install -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
88
fi

0 commit comments

Comments
 (0)