Skip to content

Commit 2397f4c

Browse files
committed
Address feedback; add todo for NumPy nightly and move default outside matrix
1 parent edcbf3c commit 2397f4c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/wheels.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,6 @@ jobs:
101101
# TODO: support PyPy?
102102
python: [["cp310", "3.10"], ["cp311", "3.11"], ["cp312", "3.12"], ["cp313", "3.13"], ["cp313t", "3.13"]]
103103
include:
104-
# 'pip' is the default
105-
- cibw_build_frontend: pip
106104
# TODO: Remove this plus installing build deps in cibw_before_build.sh
107105
# and test deps in cibw_before_test.sh after pandas can be built with a released NumPy/Cython
108106
- python: ["cp313", "3.13"]
@@ -165,7 +163,7 @@ jobs:
165163
env:
166164
CIBW_PRERELEASE_PYTHONS: True
167165
CIBW_BUILD: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }}
168-
CIBW_BUILD_FRONTEND: ${{ matrix.cibw_build_frontend }}
166+
CIBW_BUILD_FRONTEND: ${{ matrix.cibw_build_frontend || 'pip' }}
169167
CIBW_PLATFORM: ${{ matrix.buildplat[1] == 'pyodide_wasm32' && 'pyodide' || 'auto' }}
170168

171169
- name: Set up Python
@@ -189,6 +187,7 @@ jobs:
189187
- name: Test Windows Wheels
190188
if: ${{ matrix.buildplat[1] == 'win_amd64' }}
191189
shell: pwsh
190+
# TODO: Remove NumPy nightly install when there's a 3.13 wheel on PyPI
192191
run: |
193192
$TST_CMD = @"
194193
python -m pip install hypothesis>=6.84.0 pytest>=7.3.2 pytest-xdist>=3.4.0;

0 commit comments

Comments
 (0)