Fix some tests in pandas/tests/generic/test_finalize.py::test_binops

Author: fbourgey

pandas/core/base.py

@@ -1454,6 +1454,8 @@ def _duplicated(self, keep: DropKeep = "first") -> npt.NDArray[np.bool_]:
         return algorithms.duplicated(arr, keep=keep)
 
     def _arith_method(self, other, op):
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.attrs = other.attrs
         res_name = ops.get_op_result_name(self, other)
 
         lvalues = self._values
@@ -1466,9 +1468,6 @@ def _arith_method(self, other, op):
         with np.errstate(all="ignore"):
             result = ops.arithmetic_op(lvalues, rvalues, op)
 
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.attrs = other.attrs
-
         return self._construct_result(result, name=res_name)
 
     def _construct_result(self, result, name):

pandas/core/frame.py

@@ -7813,13 +7813,19 @@ class      diet
     def _cmp_method(self, other, op):
         axis: Literal[1] = 1  # only relevant for Series other case
 
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.attrs = other.attrs
+
         self, other = self._align_for_op(other, axis, flex=False, level=None)
 
         # See GH#4537 for discussion of scalar op behavior
         new_data = self._dispatch_frame_op(other, op, axis=axis)
         return self._construct_result(new_data)
 
     def _arith_method(self, other, op):
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.attrs = other.attrs
+
         if self._should_reindex_frame_op(other, op, 1, None, None):
             return self._arith_method_with_reindex(other, op)
 
@@ -7830,10 +7836,6 @@ def _arith_method(self, other, op):
 
         with np.errstate(all="ignore"):
             new_data = self._dispatch_frame_op(other, op, axis=axis)
-
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            self.attrs = other.attrs
-
         return self._construct_result(new_data)
 
     _logical_method = _arith_method
@@ -8230,6 +8232,9 @@ def _flex_cmp_method(self, other, op, *, axis: Axis = "columns", level=None):
 
         self, other = self._align_for_op(other, axis, flex=True, level=level)
 
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.attrs = other.attrs
+
         new_data = self._dispatch_frame_op(other, op, axis=axis)
         return self._construct_result(new_data)
 

pandas/core/series.py

@@ -5836,6 +5836,9 @@ def to_period(
     def _cmp_method(self, other, op):
         res_name = ops.get_op_result_name(self, other)
 
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.attrs = other.attrs
+
         if isinstance(other, Series) and not self._indexed_same(other):
             raise ValueError("Can only compare identically-labeled Series objects")
 
@@ -5847,6 +5850,8 @@ def _cmp_method(self, other, op):
         return self._construct_result(res_values, name=res_name)
 
     def _logical_method(self, other, op):
+        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
+            self.attrs = other.attrs
         res_name = ops.get_op_result_name(self, other)
         self, other = self._align_for_op(other, align_asobject=True)