Skip to content

Commit 29dda9f

Browse files
committed
ingore unused-parameter
1 parent d5b978b commit 29dda9f

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

.github/actions/build_pandas/action.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ inputs:
44
editable:
55
description: Whether to build pandas in editable mode (default true)
66
default: true
7-
werror:
8-
description: Enable werror flag for build
9-
default: true
107
runs:
118
using: composite
129
steps:
@@ -26,12 +23,12 @@ runs:
2623
shell: bash -el {0}
2724

2825
- name: Build Pandas
26+
# wno-error reason: https://github.com/cython/cython/issues/6870
2927
run: |
3028
if [[ ${{ inputs.editable }} == "true" ]]; then
31-
pip install -e . --no-build-isolation -v --no-deps \
32-
${{ inputs.werror == 'true' && '-Csetup-args="--werror"' || '' }}
29+
EDITABLE="-e"
3330
else
34-
pip install . --no-build-isolation -v --no-deps \
35-
${{ inputs.werror == 'true' && '-Csetup-args="--werror"' || '' }}
31+
EDITABLE=""
3632
fi
33+
pip install $EDITABLE . --no-build-isolation -v --no-deps -Csetup-args="-Werror" -Csetup-args="-Wno-error=unused-parameter"
3734
shell: bash -el {0}

.github/workflows/unit-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,6 @@ jobs:
160160
- name: Build Pandas
161161
id: build
162162
uses: ./.github/actions/build_pandas
163-
with:
164-
# xref https://github.com/cython/cython/issues/6870
165-
werror: ${{ matrix.name != 'Freethreading' }}
166163

167164
- name: Test (not single_cpu)
168165
uses: ./.github/actions/run-tests

0 commit comments

Comments
 (0)