Skip to content

Commit 29ee20e

Browse files
committed
TST(str dtype): Resolve xfail in test_value_counts.py
1 parent a81d52f commit 29ee20e

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

pandas/tests/frame/methods/test_to_dict_of_blocks.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,9 @@ def test_to_dict_of_blocks_item_cache():
3939

4040
df._to_dict_of_blocks()
4141

42+
values = ser.values
4243
with pytest.raises(ValueError, match="read-only"):
43-
ser.values[0] = "foo"
44+
values[0] = "foo"
4445

4546

4647
def test_set_change_dtype_slice():

pandas/tests/frame/methods/test_value_counts.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
import numpy as np
22
import pytest
33

4-
from pandas._config import using_string_dtype
5-
6-
from pandas.compat import HAS_PYARROW
7-
84
import pandas as pd
95
import pandas._testing as tm
106

@@ -136,9 +132,6 @@ def test_data_frame_value_counts_dropna_true(nulls_fixture):
136132
tm.assert_series_equal(result, expected)
137133

138134

139-
@pytest.mark.xfail(
140-
using_string_dtype() and not HAS_PYARROW, reason="TODO(infer_string)", strict=False
141-
)
142135
def test_data_frame_value_counts_dropna_false(nulls_fixture):
143136
# GH 41334
144137
df = pd.DataFrame(

0 commit comments

Comments
 (0)