Commit 2e141aa
authored
Subplot title count fix + fix for issue introduced in earlier PR (#61393)
* test case for subplot stacking
* Removed overlooked print statement
* Updated test to check other subplot in figure
* Updated test cases to include more subplot stacking possibilities
* removed savefig() left in test cases
* Updated test cases to test more arrangements
* Completed function fix (order of subplot input does not matter, need clarification if it matters)
* appeasing the great pre-commit formatter
* Updated whatsnew
* Docstring adjustment
* Moved self.subplot check to a seperate bool
* Added ignore where mypy thinks self.subplots is a bool
* Actually addressed mypy typing
* Incorperated initial PR comments
* Updated missing () after .all
* Initial test cases
* Addressed more comments on PR
* Updated '&' to 'and'
* Updated Test cases
* Fixed crash when "subplots=True" is used
* Title check checks for subplot length if specified
* Updated Test cases
* Title check checks for subplot length if specified
* Updated test name
* Removed extra '_' in test name
* Fixed issue where expected_total_height returns as a df instead of a series
* Updated change notes
* Addressed mypy error
* Addresed PR comments
* Changed exception message raised and updated test case1 parent 7595ed5 commit 2e141aa
File tree
3 files changed
+64
-10
lines changed- doc/source/whatsnew
- pandas
- plotting/_matplotlib
- tests/plotting
3 files changed
+64
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
801 | 801 | | |
802 | 802 | | |
803 | 803 | | |
| 804 | + | |
804 | 805 | | |
805 | 806 | | |
806 | 807 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
802 | 802 | | |
803 | 803 | | |
804 | 804 | | |
805 | | - | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
806 | 812 | | |
807 | 813 | | |
808 | 814 | | |
| |||
1934 | 1940 | | |
1935 | 1941 | | |
1936 | 1942 | | |
1937 | | - | |
1938 | | - | |
1939 | | - | |
1940 | | - | |
1941 | | - | |
1942 | | - | |
1943 | | - | |
| 1943 | + | |
| 1944 | + | |
| 1945 | + | |
| 1946 | + | |
| 1947 | + | |
| 1948 | + | |
| 1949 | + | |
| 1950 | + | |
1944 | 1951 | | |
1945 | 1952 | | |
1946 | 1953 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
727 | 729 | | |
728 | 730 | | |
729 | 731 | | |
730 | | - | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
731 | 737 | | |
732 | 738 | | |
733 | 739 | | |
| |||
743 | 749 | | |
744 | 750 | | |
745 | 751 | | |
746 | | - | |
747 | 752 | | |
748 | 753 | | |
749 | 754 | | |
| |||
816 | 821 | | |
817 | 822 | | |
818 | 823 | | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
0 commit comments