Skip to content

Commit 352e392

Browse files
test updates
1 parent fc824c4 commit 352e392

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

pandas/_testing/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -501,6 +501,8 @@ def shares_memory(left, right) -> bool:
501501
if isinstance(left, MultiIndex):
502502
return shares_memory(left._codes, right)
503503
if isinstance(left, (Index, Series)):
504+
if isinstance(right, (Index, Series)):
505+
return shares_memory(left._values, right._values)
504506
return shares_memory(left._values, right)
505507

506508
if isinstance(left, NDArrayBackedExtensionArray):

pandas/tests/frame/test_reductions.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,6 @@ def test_sum_bools(self):
10471047
# ----------------------------------------------------------------------
10481048
# Index of max / min
10491049

1050-
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
10511050
@pytest.mark.parametrize("axis", [0, 1])
10521051
def test_idxmin(self, float_frame, int_frame, skipna, axis):
10531052
frame = float_frame

pandas/tests/series/methods/test_reindex.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
def test_reindex(datetime_series, string_series):
2424
identity = string_series.reindex(string_series.index)
2525

26-
assert np.may_share_memory(string_series.index, identity.index)
26+
assert tm.shares_memory(string_series.index, identity.index)
2727

2828
assert identity.index.is_(string_series.index)
2929
assert identity.index.identical(string_series.index)

pandas/tests/series/methods/test_to_csv.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import numpy as np
55
import pytest
66

7-
from pandas._config import using_string_dtype
8-
97
import pandas as pd
108
from pandas import Series
119
import pandas._testing as tm
@@ -26,7 +24,6 @@ def read_csv(self, path, **kwargs):
2624

2725
return out
2826

29-
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
3027
def test_from_csv(self, datetime_series, string_series, temp_file):
3128
# freq doesn't round-trip
3229
datetime_series.index = datetime_series.index._with_freq(None)

0 commit comments

Comments
 (0)