Skip to content

Commit 458543f

Browse files
author
adrien pacifico
committed
- correct test
1 parent 7c5f3a3 commit 458543f

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

pandas/tests/reshape/concat/test_append_common.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,13 @@ def test_categorical_concat_append(self):
743743
df_different_categories = DataFrame({"cats": cat3, "vals": vals3})
744744

745745
res = pd.concat([df, df_different_categories], ignore_index=True)
746-
exp = DataFrame({"cats": list("abab"), "vals": [1, 2, 1, 2]})
746+
exp = DataFrame(
747+
{
748+
"cats": Categorical(list("abab"), categories=["a", "b", "c"]),
749+
"vals": [1, 2, 1, 2],
750+
}
751+
) # I do not agree with the test made in #37243
752+
747753
tm.assert_frame_equal(res, exp)
748754

749755
res = df._append(df_different_categories, ignore_index=True)

0 commit comments

Comments
 (0)