Skip to content

Commit 48bc0b3

Browse files
update version check and undo removed xfail in gcs/fsspec test
1 parent fc2b198 commit 48bc0b3

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

pandas/tests/io/test_fsspec.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
from pandas._config import using_string_dtype
77

8-
from pandas.compat import HAS_PYARROW
9-
108
from pandas import (
119
DataFrame,
1210
date_range,
@@ -170,9 +168,7 @@ def test_excel_options(fsspectest):
170168
assert fsspectest.test[0] == "read"
171169

172170

173-
@pytest.mark.xfail(
174-
using_string_dtype() and HAS_PYARROW, reason="TODO(infer_string) fastparquet"
175-
)
171+
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string) fastparquet")
176172
def test_to_parquet_new_file(cleared_fs, df1):
177173
"""Regression test for writing to a not-yet-existent GCS Parquet file."""
178174
pytest.importorskip("fastparquet")

pandas/tests/io/test_gcs.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
import numpy as np
88
import pytest
99

10+
from pandas._config import using_string_dtype
11+
1012
from pandas.compat.pyarrow import pa_version_under17p0
1113

1214
from pandas import (
@@ -194,6 +196,7 @@ def test_to_csv_compression_encoding_gcs(
194196
tm.assert_frame_equal(df, read_df)
195197

196198

199+
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string) fastparquet")
197200
def test_to_parquet_gcs_new_file(monkeypatch, tmpdir):
198201
"""Regression test for writing to a not-yet-existent GCS Parquet file."""
199202
pytest.importorskip("fastparquet")

pandas/tests/io/test_parquet.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1351,7 +1351,9 @@ def test_empty_dataframe(self, fp):
13511351
def test_timezone_aware_index(self, fp, timezone_aware_date_list, request):
13521352
import fastparquet
13531353

1354-
if Version(fastparquet.__version__) < Version("2024.11.0"):
1354+
if Version(fastparquet.__version__) > Version("2022.12") and Version(
1355+
fastparquet.__version__
1356+
) < Version("2024.11.0"):
13551357
request.applymarker(
13561358
pytest.mark.xfail(
13571359
reason=(

0 commit comments

Comments
 (0)