Skip to content

Commit 4e6cf04

Browse files
add TODO comment in ensure_string_array
1 parent e6aad17 commit 4e6cf04

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pandas/_libs/lib.pyx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,9 @@ cpdef ndarray[object] ensure_string_array(
757757
if (
758758
hasattr(arr, "dtype")
759759
and arr.dtype.kind in "mM"
760+
# TODO: we should add a custom ArrowExtensionArray.astype implementation
761+
# that handles astype(str) specifically, avoiding ending up here and
762+
# then we can remove the below check for `_pa_array` (for ArrowEA)
760763
and not hasattr(arr, "_pa_array")
761764
):
762765
# dtype check to exclude DataFrame

0 commit comments

Comments
 (0)