Skip to content

Commit 4ff6206

Browse files
committed
updates based on feedback
1 parent 03c33ee commit 4ff6206

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

pandas/core/frame.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
Iterator,
2121
Mapping,
2222
Sequence,
23-
Set as AbstractSet,
2423
)
2524
import functools
2625
from io import StringIO
@@ -6535,7 +6534,7 @@ def dropna(
65356534
@overload
65366535
def drop_duplicates(
65376536
self,
6538-
subset: Hashable | Sequence[Hashable] | AbstractSet | None = ...,
6537+
subset: Hashable | Sequence[Hashable] | set | None = ...,
65396538
*,
65406539
keep: DropKeep = ...,
65416540
inplace: Literal[True],
@@ -6545,7 +6544,7 @@ def drop_duplicates(
65456544
@overload
65466545
def drop_duplicates(
65476546
self,
6548-
subset: Hashable | Sequence[Hashable] | AbstractSet | None = ...,
6547+
subset: Hashable | Sequence[Hashable] | set | None = ...,
65496548
*,
65506549
keep: DropKeep = ...,
65516550
inplace: Literal[False] = ...,
@@ -6555,7 +6554,7 @@ def drop_duplicates(
65556554
@overload
65566555
def drop_duplicates(
65576556
self,
6558-
subset: Hashable | Sequence[Hashable] | AbstractSet | None = ...,
6557+
subset: Hashable | Sequence[Hashable] | set | None = ...,
65596558
*,
65606559
keep: DropKeep = ...,
65616560
inplace: bool = ...,
@@ -6564,7 +6563,7 @@ def drop_duplicates(
65646563

65656564
def drop_duplicates(
65666565
self,
6567-
subset: Hashable | Sequence[Hashable] | AbstractSet | None = None,
6566+
subset: Hashable | Sequence[Hashable] | set | None = None,
65686567
*,
65696568
keep: DropKeep = "first",
65706569
inplace: bool = False,
@@ -6668,7 +6667,7 @@ def drop_duplicates(
66686667

66696668
def duplicated(
66706669
self,
6671-
subset: Hashable | Sequence[Hashable] | AbstractSet | None = None,
6670+
subset: Hashable | Sequence[Hashable] | set | None = None,
66726671
keep: DropKeep = "first",
66736672
) -> Series:
66746673
"""
@@ -6793,13 +6792,8 @@ def f(vals) -> tuple[np.ndarray, int]:
67936792
raise KeyError(Index(diff))
67946793

67956794
if len(subset) == 1 and self.columns.is_unique:
6796-
# GH#59237 adding support for single element sets
6797-
if isinstance(subset, set):
6798-
elem = subset.pop()
6799-
else:
6800-
elem = subset[0]
68016795
# GH#45236 This is faster than get_group_index below
6802-
result = self[elem].duplicated(keep)
6796+
result = self[next(iter(subset))].duplicated(keep)
68036797
result.name = None
68046798
else:
68056799
vals = (col.values for name, col in self.items() if name in subset)

0 commit comments

Comments
 (0)