Remove version workarounds

Author: mroeschke

pandas/plotting/_matplotlib/core.py

@@ -55,7 +55,6 @@
 from pandas.core.dtypes.missing import isna
 
 import pandas.core.common as com
-from pandas.util.version import Version
 
 from pandas.io.formats.printing import pprint_thing
 from pandas.plotting._matplotlib import tools
@@ -872,10 +871,7 @@ def _make_legend(self) -> None:
             if leg is not None:
                 title = leg.get_title().get_text()
                 # Replace leg.legend_handles because it misses marker info
-                if Version(mpl.__version__) < Version("3.7"):
-                    handles = leg.legendHandles
-                else:
-                    handles = leg.legend_handles
+                handles = leg.legend_handles
                 labels = [x.get_text() for x in leg.get_texts()]
 
             if self.legend:
@@ -1213,15 +1209,10 @@ def _get_errorbars(
 
     @final
     def _get_subplots(self, fig: Figure) -> list[Axes]:
-        if Version(mpl.__version__) < Version("3.8"):
-            Klass = mpl.axes.Subplot
-        else:
-            Klass = mpl.axes.Axes
-
         return [
             ax
             for ax in fig.get_axes()
-            if (isinstance(ax, Klass) and ax.get_subplotspec() is not None)
+            if (isinstance(ax, mpl.axes.Axes) and ax.get_subplotspec() is not None)
         ]
 
     @final

pandas/tests/io/test_spss.py

@@ -169,14 +169,9 @@ def test_spss_metadata(datapath):
         "variable_measure": {"VAR00002": "unknown"},
         "file_label": None,
         "file_format": "sav/zsav",
+        "creation_time": datetime.datetime(2015, 2, 6, 14, 33, 36),
+        "modification_time": datetime.datetime(2015, 2, 6, 14, 33, 36),
     }
-    if Version(pyreadstat.__version__) >= Version("1.2.4"):
-        metadata.update(
-            {
-                "creation_time": datetime.datetime(2015, 2, 6, 14, 33, 36),
-                "modification_time": datetime.datetime(2015, 2, 6, 14, 33, 36),
-            }
-        )
     if Version(pyreadstat.__version__) >= Version("1.2.8"):
         metadata["mr_sets"] = {}
     tm.assert_dict_equal(df.attrs, metadata)

pandas/tests/io/test_sql.py

@@ -3402,13 +3402,6 @@ def test_to_sql_with_negative_npinf(conn, request, input):
         # GH 36465
         # The input {"foo": [-np.inf], "infe0": ["bar"]} does not raise any error
         # for pymysql version >= 0.10
-        # TODO(GH#36465): remove this version check after GH 36465 is fixed
-        pymysql = pytest.importorskip("pymysql")
-
-        if Version(pymysql.__version__) < Version("1.0.3") and "infe0" in df.columns:
-            mark = pytest.mark.xfail(reason="GH 36465")
-            request.applymarker(mark)
-
         msg = "inf cannot be used with MySQL"
         with pytest.raises(ValueError, match=msg):
             df.to_sql(name="foobar", con=conn, index=False)

pandas/tests/plotting/frame/test_frame_color.py

@@ -13,7 +13,6 @@
     _check_plot_works,
     _unpack_cycler,
 )
-from pandas.util.version import Version
 
 mpl = pytest.importorskip("matplotlib")
 plt = pytest.importorskip("matplotlib.pyplot")
@@ -715,10 +714,7 @@ def test_colors_of_columns_with_same_name(self):
         df_concat = pd.concat([df, df1], axis=1)
         result = df_concat.plot()
         legend = result.get_legend()
-        if Version(mpl.__version__) < Version("3.7"):
-            handles = legend.legendHandles
-        else:
-            handles = legend.legend_handles
+        handles = legend.legend_handles
         for legend, line in zip(handles, result.lines):
             assert legend.get_color() == line.get_color()
 

pandas/tests/plotting/frame/test_frame_legend.py

@@ -12,7 +12,6 @@
     _check_legend_marker,
     _check_text_labels,
 )
-from pandas.util.version import Version
 
 mpl = pytest.importorskip("matplotlib")
 
@@ -32,10 +31,7 @@ def test_mixed_yerr(self):
         df.plot("x", "b", c="blue", yerr=None, ax=ax, label="blue")
 
         legend = ax.get_legend()
-        if Version(mpl.__version__) < Version("3.7"):
-            result_handles = legend.legendHandles
-        else:
-            result_handles = legend.legend_handles
+        result_handles = legend.legend_handles
 
         assert isinstance(result_handles[0], mpl.collections.LineCollection)
         assert isinstance(result_handles[1], mpl.lines.Line2D)
@@ -48,10 +44,7 @@ def test_legend_false(self):
         ax = df.plot(legend=True, color={"a": "blue", "b": "green"}, secondary_y="b")
         df2.plot(legend=True, color={"d": "red"}, ax=ax)
         legend = ax.get_legend()
-        if Version(mpl.__version__) < Version("3.7"):
-            handles = legend.legendHandles
-        else:
-            handles = legend.legend_handles
+        handles = legend.legend_handles
         result = [handle.get_color() for handle in handles]
         expected = ["blue", "green", "red"]
         assert result == expected