Skip to content

Commit 54bf3aa

Browse files
committed
Add numeric_only to func signature
1 parent 642d244 commit 54bf3aa

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

pandas/core/groupby/groupby.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4681,12 +4681,14 @@ def rank(
46814681
@final
46824682
@Substitution(name="groupby")
46834683
@Substitution(see_also=_common_see_also)
4684-
def cumprod(self, *args, **kwargs) -> NDFrameT:
4684+
def cumprod(self, numeric_only: bool = False, *args, **kwargs) -> NDFrameT:
46854685
"""
46864686
Cumulative product for each group.
46874687
46884688
Parameters
46894689
----------
4690+
numeric_only : bool
4691+
Optional argument with default as False.
46904692
*args : tuple
46914693
Positional arguments to be passed to `func`.
46924694
**kwargs : dict
@@ -4734,18 +4736,20 @@ def cumprod(self, *args, **kwargs) -> NDFrameT:
47344736
horse 16 10
47354737
bull 6 9
47364738
"""
4737-
nv.validate_groupby_func("cumprod", args, kwargs, ["numeric_only", "skipna"])
4738-
return self._cython_transform("cumprod", **kwargs)
4739+
nv.validate_groupby_func("cumprod", args, kwargs, ["skipna"])
4740+
return self._cython_transform("cumprod", numeric_only, **kwargs)
47394741

47404742
@final
47414743
@Substitution(name="groupby")
47424744
@Substitution(see_also=_common_see_also)
4743-
def cumsum(self, *args, **kwargs) -> NDFrameT:
4745+
def cumsum(self, numeric_only: bool = False, *args, **kwargs) -> NDFrameT:
47444746
"""
47454747
Cumulative sum for each group.
47464748
47474749
Parameters
47484750
----------
4751+
numeric_only : bool
4752+
Optional argument with default as False.
47494753
*args : tuple
47504754
Positional arguments to be passed to `func`.
47514755
**kwargs : dict
@@ -4793,8 +4797,8 @@ def cumsum(self, *args, **kwargs) -> NDFrameT:
47934797
gorilla 10 7
47944798
lion 6 9
47954799
"""
4796-
nv.validate_groupby_func("cumsum", args, kwargs, ["numeric_only", "skipna"])
4797-
return self._cython_transform("cumsum", **kwargs)
4800+
nv.validate_groupby_func("cumsum", args, kwargs, ["skipna"])
4801+
return self._cython_transform("cumsum", numeric_only, **kwargs)
47984802

47994803
@final
48004804
@Substitution(name="groupby")

0 commit comments

Comments
 (0)