Skip to content

Commit 56dafc8

Browse files
committed
FIX: date comparison fails when series is all pd.NaT values #61188
1 parent a8af83d commit 56dafc8

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

pandas/core/indexes/accessors.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@
1111
)
1212
import warnings
1313

14-
1514
import numpy as np
1615

17-
18-
1916
from pandas._libs import lib
2017
from pandas.util._exceptions import find_stack_level
2118

@@ -111,7 +108,12 @@ def _delegate_property_get(self, name: str):
111108
else:
112109
index = self._parent.index
113110
# return the result as a Series
114-
return Series(result, index=index, name=self.name, dtype=result.dtype).__finalize__(self._parent)
111+
return Series(
112+
result,
113+
index=index,
114+
name=self.name,
115+
dtype=result.dtype
116+
).__finalize__(self._parent)
115117

116118
def _delegate_property_set(self, name: str, value, *args, **kwargs) -> NoReturn:
117119
raise ValueError(

pandas/tests/series/indexing/test_datetime.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -495,19 +495,19 @@ def test_compare_datetime_with_all_none():
495495
def test_dt_date_dtype_all_nat_is_object():
496496
# Ensure .dt.date on all-NaT Series returns object dtype and not datetime64
497497
# GH#61188
498-
s = pd.Series([pd.NaT, pd.NaT])
498+
s = Series([pd.NaT, pd.NaT])
499499
s = pd.to_datetime(s)
500500
result = s.dt.date
501501

502-
expected = pd.Series([pd.NaT, pd.NaT], dtype=object)
502+
expected = Series([pd.NaT, pd.NaT], dtype=object)
503503

504504
tm.assert_series_equal(result, expected)
505505

506506
def test_dt_date_all_nat_le_date():
507507
#All-NaT Series should not raise error when compared to a datetime.date
508508
# GH#61188
509-
s = pd.Series([pd.NaT, pd.NaT])
509+
s = Series([pd.NaT, pd.NaT])
510510
s = pd.to_datetime(s)
511511
result = s.dt.date <= datetime.now().date()
512-
expected = pd.Series([False, False])
512+
expected = Series([False, False])
513513
tm.assert_series_equal(result, expected)

0 commit comments

Comments
 (0)