wip

Author: MarcoGorelli

pandas/tests/series/indexing/test_setitem.py

@@ -1,3 +1,4 @@
+import contextlib
 from datetime import (
     date,
     datetime,
@@ -383,9 +384,7 @@ def test_setitem_mask_smallint_upcast(self):
         with pytest.raises(TypeError, match="Invalid value"):
             ser[mask] = Series(alt)
 
-        with tm.assert_produces_warning(
-            FutureWarning, match="item of incompatible dtype"
-        ):
+        with pytest.raises(TypeError, match="Invalid value"):
             ser.mask(mask, alt, inplace=True)
 
         res = ser.where(~mask, Series(alt))
@@ -738,58 +737,66 @@ def _check_inplace(self, is_inplace, orig, arr, obj):
     def test_int_key(self, obj, key, expected, warn, val, indexer_sli, is_inplace):
         if not isinstance(key, int):
             pytest.skip("Not relevant for int key")
+        if warn:
+            ctx = pytest.raises(TypeError, match="Invalid value")
+        else:
+            ctx = contextlib.nullcontext()
 
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, key, expected, val, indexer_sli, is_inplace)
 
         if indexer_sli is tm.loc:
-            with pytest.raises(TypeError, match="Invalid value"):
+            with ctx:
                 self.check_indexer(obj, key, expected, val, tm.at, is_inplace)
         elif indexer_sli is tm.iloc:
-            with pytest.raises(TypeError, match="Invalid value"):
+            with ctx:
                 self.check_indexer(obj, key, expected, val, tm.iat, is_inplace)
 
         rng = range(key, key + 1)
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, rng, expected, val, indexer_sli, is_inplace)
 
         if indexer_sli is not tm.loc:
             # Note: no .loc because that handles slice edges differently
             slc = slice(key, key + 1)
-            with pytest.raises(TypeError, match="Invalid value"):
+            with ctx:
                 self.check_indexer(obj, slc, expected, val, indexer_sli, is_inplace)
 
         ilkey = [key]
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, ilkey, expected, val, indexer_sli, is_inplace)
 
         indkey = np.array(ilkey)
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, indkey, expected, val, indexer_sli, is_inplace)
 
         genkey = (x for x in [key])
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, genkey, expected, val, indexer_sli, is_inplace)
 
     def test_slice_key(self, obj, key, expected, warn, val, indexer_sli, is_inplace):
         if not isinstance(key, slice):
             pytest.skip("Not relevant for slice key")
+        if warn:
+            ctx = pytest.raises(TypeError, match="Invalid value")
+        else:
+            ctx = contextlib.nullcontext()
 
         if indexer_sli is not tm.loc:
             # Note: no .loc because that handles slice edges differently
-            with pytest.raises(TypeError, match="Invalid value"):
+            with ctx:
                 self.check_indexer(obj, key, expected, val, indexer_sli, is_inplace)
 
         ilkey = list(range(len(obj)))[key]
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, ilkey, expected, val, indexer_sli, is_inplace)
 
         indkey = np.array(ilkey)
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, indkey, expected, val, indexer_sli, is_inplace)
 
         genkey = (x for x in indkey)
-        with pytest.raises(TypeError, match="Invalid value"):
+        with ctx:
             self.check_indexer(obj, genkey, expected, val, indexer_sli, is_inplace)
 
     def test_mask_key(self, obj, key, expected, warn, val, indexer_sli):
@@ -805,9 +812,11 @@ def test_mask_key(self, obj, key, expected, warn, val, indexer_sli):
                 indexer_sli(obj)[mask] = val
             return
 
-        with pytest.raises(TypeError, match="Invalid value"):
+        if warn:
+            with pytest.raises(TypeError, match="Invalid value"):
+                indexer_sli(obj)[mask] = val
+        else:
             indexer_sli(obj)[mask] = val
-        tm.assert_series_equal(obj, expected)
 
     def test_series_where(self, obj, key, expected, warn, val, is_inplace):
         mask = np.zeros(obj.shape, dtype=bool)