Brock feedback

Author: WillAyd

pandas/core/internals/blocks.py

@@ -576,10 +576,7 @@ def convert_dtypes(
     @final
     @cache_readonly
     def dtype(self) -> DtypeObj:
-        try:
-            return self.values.dtype
-        except AttributeError:  # PyArrow fallback
-            return self.values.type
+        return self.values.dtype
 
     @final
     def astype(
@@ -2237,16 +2234,12 @@ def new_block(
     *,
     ndim: int,
     refs: BlockValuesRefs | None = None,
-    dtype: DtypeObj | None,
 ) -> Block:
     # caller is responsible for ensuring:
     # - values is NOT a NumpyExtensionArray
     # - check_ndim/ensure_block_shape already checked
     # - maybe_coerce_values already called/unnecessary
-    if dtype:
-        klass = get_block_type(dtype)
-    else:
-        klass = get_block_type(values.dtype)
+    klass = get_block_type(values.dtype)
     return klass(values, ndim=ndim, placement=placement, refs=refs)
 
 

pandas/core/internals/managers.py

@@ -1978,7 +1978,6 @@ def from_blocks(
     def from_array(
         cls,
         array: ArrayLike,
-        dtype: DtypeObj | None,
         index: Index,
         refs: BlockValuesRefs | None = None,
     ) -> SingleBlockManager:
@@ -1987,7 +1986,7 @@ def from_array(
         """
         array = maybe_coerce_values(array)
         bp = BlockPlacement(slice(0, len(index)))
-        block = new_block(array, placement=bp, ndim=1, refs=refs, dtype=dtype)
+        block = new_block(array, placement=bp, ndim=1, refs=refs)
         return cls(block, index)
 
     def to_2d_mgr(self, columns: Index) -> BlockManager:

pandas/core/series.py

@@ -505,7 +505,7 @@ def __init__(
                 data = data.copy()
         else:
             data = sanitize_array(data, index, dtype, copy)
-            data = SingleBlockManager.from_array(data, dtype, index, refs=refs)
+            data = SingleBlockManager.from_array(data, index, refs=refs)
 
         NDFrame.__init__(self, data)
         self.name = name

pandas/io/formats/format.py

@@ -1103,11 +1103,7 @@ def format_array(
     List[str]
     """
     fmt_klass: type[_GenericArrayFormatter]
-    if hasattr(values, "type") and values.type == "null":
-        fmt_klass = _NullFormatter
-    if hasattr(values, "type") and str(values.type).startswith("list"):
-        fmt_klass = _ListFormatter
-    elif lib.is_np_dtype(values.dtype, "M"):
+    if lib.is_np_dtype(values.dtype, "M"):
         fmt_klass = _Datetime64Formatter
         values = cast(DatetimeArray, values)
     elif isinstance(values.dtype, DatetimeTZDtype):