test_common changed

Author: xaris96

pandas/tests/indexes/multi/test_setops.py

@@ -629,7 +629,8 @@ def test_union_duplicates(index, request):
     # special case for mixed types
     if index.inferred_type == "mixed":
         pytest.mark.xfail(
-            reason="GH#38977 - mixed type union with duplicates is not supported")
+            reason="GH#38977 - mixed type union with duplicates is not supported"
+        )
 
     # GH#38977
     if index.empty or isinstance(index, (IntervalIndex, CategoricalIndex)):

pandas/tests/indexes/test_common.py

@@ -438,10 +438,43 @@ def test_hasnans_isnans(self, index_flat):
 
 
 @pytest.mark.filterwarnings(r"ignore:PeriodDtype\[B\] is deprecated:FutureWarning")
-@pytest.mark.parametrize("na_position", [None, "middle"])
-def test_sort_values_invalid_na_position(index_with_missing, na_position):
-    if len({type(x) for x in index_with_missing if pd.notna(x)}) > 1:
-        index_with_missing = index_with_missing.map(str)
+@pytest.mark.parametrize(
+    "na_position,index_fixture",
+    [
+        pytest.param(
+            None,
+            "mixed-int-string",
+            marks=pytest.mark.xfail(reason="Mixed index types"),
+        ),
+        pytest.param(
+            "middle",
+            "mixed-int-string",
+            marks=pytest.mark.xfail(reason="Mixed index types"),
+        ),
+        pytest.param(
+            None, "object", marks=pytest.mark.xfail(reason="Object index types")
+        ),
+        pytest.param(
+            "middle", "object", marks=pytest.mark.xfail(reason="Object index types")
+        ),
+    ],
+)
+def test_sort_values_invalid_na_position(request, na_position, index_fixture):
+    index_with_missing = request.getfixturevalue(index_fixture)
+
+    if getattr(index_with_missing, "inferred_type", None) in [
+        "mixed",
+        "mixed-integer",
+        "object",
+        "string",
+        "boolean",
+    ]:
+        request.applymarker(
+            pytest.mark.xfail(
+                reason="inferred_type not supported "
+                "in sort_values with invalid na_position"
+            )
+        )
 
     with pytest.raises(ValueError, match=f"invalid na_position: {na_position}"):
         index_with_missing.sort_values(na_position=na_position)