Skip to content

Commit 6b0a91b

Browse files
authored
Apply suggestions from code review
1 parent fee405b commit 6b0a91b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

web/pandas/pdeps/0008-inplace-methods-in-pandas.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
- Created: 16 February 2023
44
- Status: Under discussion
5-
- Discussion: [PR xxx](https://github.com/pandas-dev/pandas/pull/xxx)
5+
- Discussion: [PR 51466](https://github.com/pandas-dev/pandas/pull/51466)
66
- Authors: [Thomas Li](https://github.com/lithomas1),
77
[Patrick Hoefler](https://github.com/phofl),
88
[Joris Van den Bossche](https://github.com/jorisvandenbossche)
@@ -30,7 +30,7 @@ This PDEP proposes that:
3030
(These questions are deferred to a later revision, and will not affect the acceptance process of this PDEP.)
3131
- Should ``inplace=True`` return the original pandas object that was operated inplace on?
3232
- What should happen when ``inplace=True`` but the original pandas object cannot be operated inplace on because it
33-
shares its values with another object?
33+
shares its values with another pandas object?
3434

3535
## Motivation and Scope
3636

@@ -121,7 +121,7 @@ inplace (it will remove the values of the column being set, and insert new value
121121
| ``bfill`` |
122122
| ``clip`` |
123123

124-
These methods don't operate inplace by default, but can be done inplace with `inplace=True`. All those methods leave
124+
These methods don't operate inplace by default, but can be done inplace with `inplace=True` if the dtypes are compatible (e.g. the values replacing the old values can be stored in the original array without an astype). All those methods leave
125125
the structure of the DataFrame or Series intact (shape, row/column labels), but can mutate some elements of the data of
126126
the DataFrame or Series.
127127

0 commit comments

Comments
 (0)