Skip to content

Commit 75f0b15

Browse files
committed
Fix tests and add documentation
1 parent eb7f82f commit 75f0b15

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

doc/source/whatsnew/v3.0.0.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,7 @@ Groupby/resample/rolling
610610
- Bug in :meth:`DataFrameGroupBy.agg` that raises ``AttributeError`` when there is dictionary input and duplicated columns, instead of returning a DataFrame with the aggregation of all duplicate columns. (:issue:`55041`)
611611
- Bug in :meth:`DataFrameGroupBy.apply` that was returning a completely empty DataFrame when all return values of ``func`` were ``None`` instead of returning an empty DataFrame with the original columns and dtypes. (:issue:`57775`)
612612
- Bug in :meth:`DataFrameGroupBy.apply` with ``as_index=False`` that was returning :class:`MultiIndex` instead of returning :class:`Index`. (:issue:`58291`)
613+
- Bug in :meth:`DataFrameGroupBy.cumsum` and :meth:`DataFrameGroupBy.cumprod` where ``numeric_only`` parameter was passed indirectly through kwargs instead of passing directly. (:issue:`58811`)
613614
- Bug in :meth:`DataFrameGroupBy.cumsum` where it did not return the correct dtype when the label contained ``None``. (:issue:`58811`)
614615
- Bug in :meth:`DataFrameGroupby.transform` and :meth:`SeriesGroupby.transform` with a reducer and ``observed=False`` that coerces dtype to float when there are unobserved categories. (:issue:`55326`)
615616
- Bug in :meth:`Rolling.apply` where the applied function could be called on fewer than ``min_period`` periods if ``method="table"``. (:issue:`58868`)

pandas/tests/groupby/test_api.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def test_frame_consistency(groupby_func):
185185
elif groupby_func in ("cummax", "cummin"):
186186
exclude_expected = {"axis", "skipna", "args"}
187187
elif groupby_func in ("cumprod", "cumsum"):
188-
exclude_expected = {"axis", "skipna", "numeric_only"}
188+
exclude_expected = {"axis", "skipna"}
189189
elif groupby_func in ("pct_change",):
190190
exclude_expected = {"kwargs"}
191191
elif groupby_func in ("rank",):
@@ -245,6 +245,7 @@ def test_series_consistency(request, groupby_func):
245245
exclude_result = {"numeric_only"}
246246
elif groupby_func in ("cumprod", "cumsum"):
247247
exclude_expected = {"skipna"}
248+
exclude_result = {"numeric_only"}
248249
elif groupby_func in ("pct_change",):
249250
exclude_expected = {"kwargs"}
250251
elif groupby_func in ("rank",):

0 commit comments

Comments
 (0)