move methods to subclass

Author: jbrockmendel

pandas/core/arrays/arrow/array.py

@@ -734,14 +734,7 @@ def _cmp_method(self, other, op) -> ArrowExtensionArray:
             raise NotImplementedError(
                 f"{op.__name__} not implemented for {type(other)}"
             )
-        result = ArrowExtensionArray(result)
-        if self.dtype.na_value is np.nan:  # type: ignore[comparison-overlap]
-            # i.e. ArrowStringArray with Numpy Semantics
-            if op == operator.ne:
-                return result.to_numpy(np.bool_, na_value=True)
-            else:
-                return result.to_numpy(np.bool_, na_value=False)
-        return result
+        return ArrowExtensionArray(result)
 
     def _evaluate_op_method(self, other, op, arrow_funcs) -> Self:
         pa_type = self._pa_array.type
@@ -1536,11 +1529,7 @@ def value_counts(self, dropna: bool = True) -> Series:
 
         index = Index(type(self)(values))
 
-        result = Series(counts, index=index, name="count", copy=False)
-        if self.dtype.na_value is np.nan:  # type: ignore[comparison-overlap]
-            # i.e. ArrowStringArray with Numpy Semantics
-            return Series(counts.to_numpy(), index=index, name="count", copy=False)
-        return result
+        return Series(counts, index=index, name="count", copy=False)
 
     @classmethod
     def _concat_same_type(cls, to_concat) -> Self:

pandas/core/arrays/string_arrow.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import operator
 import re
 from typing import (
     TYPE_CHECKING,
@@ -60,6 +61,8 @@
 
     from pandas.core.dtypes.dtypes import ExtensionDtype
 
+    from pandas import Series
+
 
 ArrowStringScalarOrNAT = Union[str, libmissing.NAType]
 
@@ -551,6 +554,24 @@ def _rank(
             )
         )
 
+    def value_counts(self, dropna: bool = True) -> Series:
+        result = super().value_counts(dropna=dropna)
+        if self.dtype.na_value is np.nan:
+            res_values = result._values.to_numpy()
+            return result._constructor(
+                res_values, index=result.index, name=result.name, copy=False
+            )
+        return result
+
+    def _cmp_method(self, other, op):
+        result = super()._cmp_method(other, op)
+        if self.dtype.na_value is np.nan:
+            if op == operator.ne:
+                return result.to_numpy(np.bool_, na_value=True)
+            else:
+                return result.to_numpy(np.bool_, na_value=False)
+        return result
+
 
 class ArrowStringArrayNumpySemantics(ArrowStringArray):
     _na_value = np.nan