fixup allow_2d

Author: jorisvandenbossche

pandas/core/arrays/datetimelike.py

@@ -669,7 +669,7 @@ def _validate_listlike(self, value, allow_object: bool = False):
 
         # Do type inference if necessary up front
         # e.g. we passed PeriodIndex.values and got an ndarray of Periods
-        value = sanitize_array(value, index=None)
+        value = sanitize_array(value, index=None, allow_2d=True)
         value = ensure_wrapped_if_datetimelike(value)
 
         if is_all_strings(value):

pandas/core/construction.py

@@ -37,7 +37,6 @@
 from pandas.core.dtypes.common import (
     ensure_object,
     is_list_like,
-    is_object_dtype,
     pandas_dtype,
 )
 from pandas.core.dtypes.dtypes import NumpyEADtype
@@ -49,8 +48,6 @@
 )
 from pandas.core.dtypes.missing import isna
 
-import pandas.core.common as com
-
 if TYPE_CHECKING:
     from collections.abc import Sequence
 
@@ -706,23 +703,12 @@ def _sanitize_ndim(
         result = _maybe_repeat(result, index)
 
     elif result.ndim > 1:
-        if isinstance(data, np.ndarray):
-            if allow_2d:
-                return result
-            raise ValueError(
-                f"Data must be 1-dimensional, got ndarray of shape {data.shape} instead"
-            )
-        if is_object_dtype(dtype) and isinstance(dtype, ExtensionDtype):
-            # i.e. NumpyEADtype("O")
+        if allow_2d:
+            return result
+        raise ValueError(
+            f"Data must be 1-dimensional, got ndarray of shape {data.shape} instead"
+        )
 
-            result = com.asarray_tuplesafe(data, dtype=np.dtype("object"))
-            cls = dtype.construct_array_type()
-            result = cls._from_sequence(result, dtype=dtype)
-        else:
-            # error: Argument "dtype" to "asarray_tuplesafe" has incompatible type
-            # "Union[dtype[Any], ExtensionDtype, None]"; expected "Union[str,
-            # dtype[Any], None]"
-            result = com.asarray_tuplesafe(data, dtype=dtype)  # type: ignore[arg-type]
     return result
 
 

pandas/tests/arrays/test_datetimelike.py

@@ -336,7 +336,7 @@ def test_searchsorted_castable_strings(
                 match=re.escape(
                     f"value should be a '{arr1d._scalar_type.__name__}', 'NaT', "
                     "or array of those. Got "
-                    f"{'str' if using_infer_string else 'string'} array instead."
+                    f"{'str' if using_infer_string else 'object'} array instead."
                 ),
             ):
                 arr.searchsorted([str(arr[1]), "baz"])