Skip to content

Commit 90c4672

Browse files
add comments
1 parent 3bb6ea9 commit 90c4672

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

pandas/core/array_algos/masked_reductions.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ def _reductions(
6363
return libmissing.NA
6464

6565
if values.dtype == np.dtype(object):
66+
# object dtype does not support `where` without passing an initial
6667
values = values[~mask]
6768
return func(values, axis=axis, **kwargs)
6869
return func(values, where=~mask, axis=axis, **kwargs)

pandas/core/arrays/arrow/array.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1730,6 +1730,7 @@ def pyarrow_meth(data, skip_nulls, min_count=0):
17301730
return pa.scalar(None, type=data.type)
17311731

17321732
if pa.types.is_large_string(data.type):
1733+
# binary_join only supports string, not large_string
17331734
data = data.cast(pa.string())
17341735
data_list = pa.ListArray.from_arrays(
17351736
[0, len(data)], data.combine_chunks()

0 commit comments

Comments
 (0)