Skip to content

Commit 9822a66

Browse files
committed
resolve repr change and empty grouper bug
1 parent 692c153 commit 9822a66

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

pandas/core/groupby/grouper.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,13 +285,19 @@ def __init__(
285285
self.level = level
286286
self.freq = freq
287287
self.sort = sort
288-
self.dropna = dropna
288+
self._dropna = dropna
289289

290290
self._indexer_deprecated: npt.NDArray[np.intp] | None = None
291291
self.binner = None
292292
self._grouper = None
293293
self._indexer: npt.NDArray[np.intp] | None = None
294294

295+
@property
296+
def dropna(self):
297+
if self._dropna is lib.no_default:
298+
return True
299+
return self._dropna
300+
295301
def _get_grouper(
296302
self, obj: NDFrameT, validate: bool = True
297303
) -> tuple[ops.BaseGrouper, NDFrameT]:
@@ -694,7 +700,7 @@ def _codes_and_uniques(self) -> tuple[npt.NDArray[np.signedinteger], ArrayLike]:
694700
if (
695701
get_option("null_grouper_warning")
696702
and unspecified_dropna
697-
and codes.min() == -1
703+
and codes.min(initial=0) == -1
698704
):
699705
warnings.warn(
700706
_NULL_KEY_MESSAGE,

0 commit comments

Comments
 (0)