Skip to content

Commit a5e5065

Browse files
committed
Address some PR feedback
1 parent 5ac82aa commit a5e5065

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

pandas/core/tools/numeric.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,8 @@ def to_numeric(
222222

223223
values_dtype = getattr(values, "dtype", None)
224224
if isinstance(values_dtype, ArrowDtype):
225-
if is_numeric_dtype(values_dtype):
226-
if is_series:
227-
return arg._constructor(values, index=arg.index, name=arg.name)
228-
else:
229-
return values
225+
if is_numeric_dtype(values_dtype) and is_series:
226+
return arg._constructor(values, index=arg.index, name=arg.name)
230227

231228
mask = values.isna()
232229
values = values.dropna().to_numpy()

pandas/tests/tools/test_to_numeric.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -921,12 +921,18 @@ def test_coerce_pyarrow_backend():
921921
tm.assert_series_equal(result, expected)
922922

923923

924-
def test_to_numeric_arrow_decimal_with_na():
924+
@pytest.mark.parametrize(
925+
"dtype",
926+
[
927+
"ArrowDtype",
928+
],
929+
)
930+
def test_to_numeric_arrow_decimal_with_na(dtype):
925931
# GH 61641
926932
pa = pytest.importorskip("pyarrow")
927-
decimal_type = ArrowDtype(pa.decimal128(3, scale=2))
933+
target_class = globals()[dtype]
934+
decimal_type = target_class(pa.decimal128(3, scale=2))
928935
series = Series([1, None], dtype=decimal_type)
929936
result = to_numeric(series, errors="coerce")
930937

931-
expected = Series([1.00, pd.NA], dtype=decimal_type)
932-
tm.assert_series_equal(result, expected)
938+
tm.assert_series_equal(result, series)

0 commit comments

Comments
 (0)