Skip to content

Commit a7abee3

Browse files
address feedback: use _values in tests + add comment
1 parent 1765fe7 commit a7abee3

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

pandas/core/arrays/sparse/array.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -993,6 +993,7 @@ def __getitem__(
993993
data_slice = self.to_dense()[key] # type: ignore[index]
994994
elif isinstance(key, slice):
995995
if key == slice(None):
996+
# to ensure arr[:] (used by view()) does not make a copy
996997
return type(self)._simple_new(self.sp_values, self.sp_index, self.dtype)
997998
# Avoid densifying when handling contiguous slices
998999
if key.step is None or key.step == 1:

pandas/tests/arrays/test_datetimelike.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1248,8 +1248,8 @@ def test_invalid_nat_setitem_array(arr, non_casting_nats):
12481248
@pytest.mark.parametrize(
12491249
"arr",
12501250
[
1251-
pd.date_range("2000", periods=4).array.copy(),
1252-
pd.timedelta_range("2000", periods=4).array.copy(),
1251+
pd.date_range("2000", periods=4)._values,
1252+
pd.timedelta_range("2000", periods=4)._values,
12531253
],
12541254
)
12551255
def test_to_numpy_extra(arr):

pandas/tests/extension/test_numpy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def allow_in_pandas(monkeypatch):
7777
@pytest.fixture
7878
def data(allow_in_pandas, dtype):
7979
if dtype.numpy_dtype == "object":
80-
return pd.Series([(i,) for i in range(100)]).array.copy()
80+
return pd.Series([(i,) for i in range(100)])._values
8181
return NumpyExtensionArray(np.arange(1, 101, dtype=dtype._dtype))
8282

8383

0 commit comments

Comments
 (0)