Skip to content

Commit adbce63

Browse files
committed
FIx typing
1 parent d922a51 commit adbce63

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pandas/core/reshape/concat.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -400,6 +400,7 @@ def concat(
400400
raise ValueError(
401401
f"The 'sort' keyword only accepts boolean values; {sort} was passed."
402402
)
403+
sort = bool(sort)
403404

404405
objs, keys, ndims = _clean_keys_and_objs(objs, keys)
405406

@@ -519,7 +520,7 @@ def _get_result(
519520
res = concat_compat(arrs, axis=0)
520521

521522
if ignore_index:
522-
new_index = default_index(len(res))
523+
new_index: Index = default_index(len(res))
523524
else:
524525
new_index = _get_concat_axis_series(
525526
objs,
@@ -656,7 +657,7 @@ def _get_concat_axis_series(
656657
raise ValueError(f"Indexes have overlapping values: {overlap}")
657658
return concat_axis
658659
elif keys is None:
659-
names: list[Hashable] = [None] * len(objs)
660+
result_names: list[Hashable] = [None] * len(objs)
660661
num = 0
661662
has_names = False
662663
for i, x in enumerate(objs):
@@ -666,17 +667,17 @@ def _get_concat_axis_series(
666667
f"object of type '{type(x).__name__}'"
667668
)
668669
if x.name is not None:
669-
names[i] = x.name
670+
result_names[i] = x.name
670671
has_names = True
671672
else:
672-
names[i] = num
673+
result_names[i] = num
673674
num += 1
674675
if has_names:
675-
return Index(names)
676+
return Index(result_names)
676677
else:
677678
return default_index(len(objs))
678679
else:
679-
return ensure_index(keys).set_names(names)
680+
return ensure_index(keys).set_names(names) # type: ignore[arg-type]
680681

681682

682683
def _get_concat_axis_dataframe(
@@ -689,12 +690,12 @@ def _get_concat_axis_dataframe(
689690
verify_integrity: bool,
690691
) -> Index:
691692
"""Return result concat axis when concatenating DataFrame objects."""
692-
indexes = (x.axes[axis] for x in objs)
693+
indexes_gen = (x.axes[axis] for x in objs)
693694

694695
if ignore_index:
695-
return default_index(sum(len(i) for i in indexes))
696+
return default_index(sum(len(i) for i in indexes_gen))
696697
else:
697-
indexes = list(indexes)
698+
indexes = list(indexes_gen)
698699

699700
if keys is None:
700701
if levels is not None:

0 commit comments

Comments
 (0)