Skip to content

Commit b9b3197

Browse files
committed
Revert "Move test"
This reverts commit 6f93a8d.
1 parent 6f93a8d commit b9b3197

File tree

3 files changed

+19
-43
lines changed

3 files changed

+19
-43
lines changed

pandas/conftest.py

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
except ImportError:
9393
has_pyarrow = False
9494
else:
95+
del pa
9596
has_pyarrow = True
9697

9798
import zoneinfo
@@ -1366,25 +1367,6 @@ def any_string_dtype(request):
13661367
return request.param
13671368

13681369

1369-
@pytest.fixture(
1370-
params=[
1371-
"object",
1372-
"string[python]",
1373-
pytest.param("string[pyarrow]", marks=td.skip_if_no("pyarrow")),
1374-
pytest.param("string[pyarrow_numpy]", marks=td.skip_if_no("pyarrow")),
1375-
pytest.param(pd.ArrowDtype(pa.string()), marks=td.skip_if_no("pyarrow")),
1376-
]
1377-
)
1378-
def any_string_dtype_2(request):
1379-
"""
1380-
Parametrized fixture for string dtypes.
1381-
* 'object'
1382-
* 'string[python]'
1383-
* 'string[pyarrow]'
1384-
"""
1385-
return request.param
1386-
1387-
13881370
@pytest.fixture(params=tm.DATETIME64_DTYPES)
13891371
def datetime64_dtype(request):
13901372
"""

pandas/tests/extension/test_arrow.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2296,6 +2296,16 @@ def test_str_split_pat_none(method):
22962296
tm.assert_series_equal(result, expected)
22972297

22982298

2299+
def test_str_split_regex_none():
2300+
# GH 58321
2301+
ser = pd.Series(["230/270/270", "240-290-290"], dtype=ArrowDtype(pa.string()))
2302+
result = ser.str.split(r"/|-", regex=None)
2303+
expected = pd.Series(
2304+
ArrowExtensionArray(pa.array([["230", "270", "270"], ["240", "290", "290"]]))
2305+
)
2306+
tm.assert_series_equal(result, expected)
2307+
2308+
22992309
def test_str_split():
23002310
# GH 52401
23012311
ser = pd.Series(["a1cbcb", "a2cbcb", None], dtype=ArrowDtype(pa.string()))

pandas/tests/strings/test_split_partition.py

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
object_pyarrow_numpy,
1818
)
1919

20-
pa = pytest.importorskip("pyarrow")
21-
22-
from pandas.core.arrays.arrow.array import ArrowExtensionArray
23-
2420

2521
@pytest.mark.parametrize("method", ["split", "rsplit"])
2622
def test_split(any_string_dtype, method):
@@ -63,39 +59,27 @@ def test_split_regex(any_string_dtype):
6359
tm.assert_series_equal(result, exp)
6460

6561

66-
def test_split_regex_explicit(any_string_dtype_2):
62+
def test_split_regex_explicit(any_string_dtype):
6763
# explicit regex = True split with compiled regex
6864
regex_pat = re.compile(r".jpg")
69-
values = Series("xxxjpgzzz.jpg", dtype=any_string_dtype_2)
70-
71-
if not isinstance(any_string_dtype_2, pd.ArrowDtype):
72-
# ArrowDtype does not support compiled regex
73-
result = values.str.split(regex_pat)
74-
exp = Series([["xx", "zzz", ""]])
75-
tm.assert_series_equal(result, exp)
65+
values = Series("xxxjpgzzz.jpg", dtype=any_string_dtype)
66+
result = values.str.split(regex_pat)
67+
exp = Series([["xx", "zzz", ""]])
68+
tm.assert_series_equal(result, exp)
7669

7770
# explicit regex = False split
7871
result = values.str.split(r"\.jpg", regex=False)
79-
if not isinstance(any_string_dtype_2, pd.ArrowDtype):
80-
exp = Series([["xxxjpgzzz.jpg"]])
81-
else:
82-
exp = Series(ArrowExtensionArray(pa.array([["xxxjpgzzz.jpg"]])))
72+
exp = Series([["xxxjpgzzz.jpg"]])
8373
tm.assert_series_equal(result, exp)
8474

8575
# non explicit regex split, pattern length == 1
8676
result = values.str.split(r".")
87-
if not isinstance(any_string_dtype_2, pd.ArrowDtype):
88-
exp = Series([["xxxjpgzzz", "jpg"]])
89-
else:
90-
exp = Series(ArrowExtensionArray(pa.array([["xxxjpgzzz", "jpg"]])))
77+
exp = Series([["xxxjpgzzz", "jpg"]])
9178
tm.assert_series_equal(result, exp)
9279

9380
# non explicit regex split, pattern length != 1
9481
result = values.str.split(r".jpg")
95-
if not isinstance(any_string_dtype_2, pd.ArrowDtype):
96-
exp = Series([["xx", "zzz", ""]])
97-
else:
98-
exp = Series(ArrowExtensionArray(pa.array([["xx", "zzz", ""]])))
82+
exp = Series([["xx", "zzz", ""]])
9983
tm.assert_series_equal(result, exp)
10084

10185
# regex=False with pattern compiled regex raises error

0 commit comments

Comments
 (0)