Skip to content

Commit be4e2d9

Browse files
committed
changes post review
1 parent 8840256 commit be4e2d9

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

doc/source/whatsnew/v3.0.0.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,6 @@ Other Removals
490490
- Removed the ``method`` keyword in ``ExtensionArray.fillna``, implement ``ExtensionArray._pad_or_backfill`` instead (:issue:`53621`)
491491
- Removed the attribute ``dtypes`` from :class:`.DataFrameGroupBy` (:issue:`51997`)
492492
- Enforced deprecation of ``argmin``, ``argmax``, ``idxmin``, and ``idxmax`` returning a result when ``skipna=False`` and an NA value is encountered or all values are NA values; these operations will now raise in such cases (:issue:`33941`, :issue:`51276`)
493-
- Removed support for ``action="ignore"`` for :class:`SeriesApply` in :meth:`SeriesApply.apply_standard`, categorical NA value now returns ``False`` (:issue:`59938`)
494493

495494
.. ---------------------------------------------------------------------------
496495
.. _whatsnew_300.performance:
@@ -545,7 +544,7 @@ Bug fixes
545544

546545
Categorical
547546
^^^^^^^^^^^
548-
-
547+
- Removed support for ``action="ignore"`` for :class:`SeriesApply` in :meth:`SeriesApply.apply_standard`, categorical NA value now returns ``False`` (:issue:`59938`)
549548
-
550549

551550
Datetimelike

pandas/core/apply.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1462,10 +1462,6 @@ def curried(x):
14621462

14631463
else:
14641464
curried = func
1465-
1466-
# remove the `na_action="ignore"` as default has been changed in
1467-
# Categorical (GH 51645).
1468-
# Reference for below fix (GH 59966)
14691465
mapped = obj._map_values(mapper=curried)
14701466

14711467
if len(mapped) and isinstance(mapped[0], ABCSeries):

pandas/tests/apply/test_frame_apply.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,8 @@ def test_apply_category_equalness(val):
742742
result = df.a.apply(lambda x: x == val)
743743
expected = Series(
744744
[False if pd.isnull(x) else x == val for x in df_values], name="a"
745-
) # False since behavior of NaN for categorical dtype has been changed (GH 59966)
745+
)
746+
# False since behavior of NaN for categorical dtype has been changed (GH 59966)
746747
tm.assert_series_equal(result, expected)
747748

748749

0 commit comments

Comments
 (0)