Skip to content

Commit c04969e

Browse files
committed
cleanups
1 parent 188f92e commit c04969e

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

pandas/core/arrays/string_.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -899,16 +899,6 @@ def _accumulate(self, name: str, *, skipna: bool = True, **kwargs) -> StringArra
899899
------
900900
NotImplementedError : subclass does not define accumulations
901901
"""
902-
if is_string_dtype(self):
903-
return self._str_accumulate(name=name, skipna=skipna, **kwargs)
904-
return super()._accumulate(name=name, skipna=skipna, **kwargs)
905-
906-
def _str_accumulate(
907-
self, name: str, *, skipna: bool = True, **kwargs
908-
) -> StringArray:
909-
"""
910-
Accumulate implementation for strings, see `_accumulate` docstring for details.
911-
"""
912902
if name == "cumprod":
913903
msg = f"operation '{name}' not supported for dtype '{self.dtype}'"
914904
raise TypeError(msg)

pandas/tests/groupby/test_categorical.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,7 @@ def test_observed(request, using_infer_string, observed):
358358
expected = cartesian_product_for_groupers(
359359
expected, [cat1, cat2], list("AB"), fill_value=0
360360
)
361+
361362
tm.assert_frame_equal(result, expected)
362363

363364

0 commit comments

Comments
 (0)