Skip to content

Commit de62a67

Browse files
committed
Parallelize test_sql.py - attempt to close iris db connections
1 parent 0983d76 commit de62a67

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

pandas/tests/io/test_sql.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def create_and_load_iris_sqlite3(conn, iris_file: Path, iris_uuid):
146146
"PetalWidth" REAL,
147147
"Name" TEXT
148148
)"""
149-
sqlalchemy = pytest.importorskip(sqlalchemy)
149+
sqlalchemy = pytest.importorskip("sqlalchemy")
150150

151151
if type(conn) == sqlalchemy.engine.base.Engine:
152152
conn = conn.raw_connection()
@@ -698,6 +698,8 @@ def mysql_pymysql_engine_iris(request, mysql_pymysql_engine, iris_path):
698698

699699
yield conn, iris_table_uuid, iris_view_uuid
700700

701+
conn.dispose()
702+
701703

702704
@pytest.fixture
703705
def mysql_pymysql_engine_types(mysql_pymysql_engine, types_data):
@@ -715,6 +717,7 @@ def mysql_pymysql_conn_iris(mysql_pymysql_engine_iris):
715717
engine, iris_table_uuid, iris_view_uuid = mysql_pymysql_engine_iris
716718
with engine.connect() as conn:
717719
yield conn, iris_table_uuid, iris_view_uuid
720+
engine.dispose()
718721

719722

720723
@pytest.fixture
@@ -750,6 +753,7 @@ def postgresql_psycopg2_engine_iris(request, postgresql_psycopg2_engine, iris_pa
750753
create_and_load_iris_view(conn, iris_table_uuid, iris_view_uuid)
751754

752755
yield conn, iris_table_uuid, iris_view_uuid
756+
conn.dispose()
753757

754758

755759
@pytest.fixture
@@ -789,6 +793,7 @@ def postgresql_adbc_iris(request, postgresql_adbc_conn, iris_path):
789793
create_and_load_iris_view(conn, iris_table_uuid, iris_view_uuid)
790794

791795
yield conn, iris_table_uuid, iris_view_uuid
796+
conn.drop()
792797

793798

794799
@pytest.fixture
@@ -951,7 +956,7 @@ def sqlite_buildin_iris(request, sqlite_buildin, iris_path):
951956
create_and_load_iris_sqlite3(conn, iris_path, iris_table_uuid)
952957
create_and_load_iris_view(conn, iris_table_uuid, iris_view_uuid)
953958
yield conn, iris_table_uuid, iris_view_uuid
954-
conn.close()
959+
# conn.close()
955960

956961

957962
@pytest.fixture
@@ -1064,6 +1069,11 @@ def iris_connect_and_per_test_id(request, iris_path):
10641069
conn = sqlalchemy.create_engine(conn)
10651070
drop_view(view_uuid, conn)
10661071
drop_table(table_uuid, conn)
1072+
if isinstance(conn, sqlalchemy.Engine):
1073+
conn.dispose()
1074+
else:
1075+
conn.close()
1076+
10671077

10681078

10691079
connectables_to_create_uuid_function_map = {

0 commit comments

Comments
 (0)