Skip to content

Commit e71250b

Browse files
committed
Add unused-parameter to meson build instead
1 parent b2d36a0 commit e71250b

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.github/actions/build_pandas/action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,11 @@ runs:
2323
shell: bash -el {0}
2424

2525
- name: Build Pandas
26-
# wno-error reason: https://github.com/cython/cython/issues/6870
2726
run: |
2827
if [[ ${{ inputs.editable }} == "true" ]]; then
2928
EDITABLE="-e"
3029
else
3130
EDITABLE=""
3231
fi
33-
pip install $EDITABLE . --no-build-isolation -v --no-deps --config-settings=setup-args="-Werror" --config-settings=setup-args="-Wno-error=unused-parameter"
32+
pip install $EDITABLE . --no-build-isolation -v --no-deps -Ccompile-args="-Werror"
3433
shell: bash -el {0}

meson.build

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ else
4444
meson.add_dist_script(py, versioneer, '-o', '_version_meson.py')
4545
endif
4646

47+
cc = meson.get_compiler('c')
48+
add_project_arguments(
49+
# https://github.com/cython/cython/issues/6870
50+
cc.get_supported_arguments(['-Wno-error=unused-parameter']),
51+
language: 'c',
52+
)
4753
cy = meson.get_compiler('cython')
4854
if cy.version().version_compare('>=3.1.0')
4955
add_project_arguments('-Xfreethreading_compatible=true', language: 'cython')

0 commit comments

Comments
 (0)