Skip to content

Commit e7c4911

Browse files
veljaninyuanx749
authored andcommitted
additional revisions
1 parent 9d415ea commit e7c4911

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

pandas/core/dtypes/cast.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,14 +1143,15 @@ def convert_dtypes(
11431143
base_dtype.kind == "O" # type: ignore[union-attr]
11441144
and input_array.size > 0
11451145
and isna(input_array).all()
1146+
and not isinstance(input_array.dtype, CategoricalDtype)
11461147
):
11471148
import pyarrow as pa
1148-
1149+
11491150
pa_type = pa.null()
11501151
else:
11511152
pa_type = to_pyarrow_type(base_dtype)
11521153
if pa_type is not None:
1153-
if isna(input_array).all() and hasattr(input_array, 'categories'):
1154+
if isna(input_array).all() and hasattr(input_array, "categories"):
11541155
inferred_dtype = input_array.dtype
11551156
else:
11561157
inferred_dtype = ArrowDtype(pa_type)

pandas/tests/frame/methods/test_convert_dtypes.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,27 @@ def test_convert_empty(self):
3434
# Empty DataFrame can pass convert_dtypes, see GH#40393
3535
empty_df = pd.DataFrame()
3636
tm.assert_frame_equal(empty_df, empty_df.convert_dtypes())
37-
37+
3838
def test_convert_empty_categorical_to_pyarrow(self):
39+
# GH#59934
3940
df = pd.DataFrame(
4041
{
41-
"A": pd.Series(pd.Categorical([None] * 5)),
42-
"B": pd.Series(pd.Categorical([None] * 5, categories=["B1", "B2"])),
43-
}
42+
"A": pd.Categorical([None] * 5),
43+
"B": pd.Categorical([None] * 5, categories=["B1", "B2"]),
44+
}
4445
)
4546
converted = df.convert_dtypes(dtype_backend="pyarrow")
4647
expected = df
4748
tm.assert_frame_equal(converted, expected)
48-
49-
assert df.A.dtype == "category", "Dtype in column A is not 'category'"
50-
assert df.B.dtype == "category", "Dtype in column B is not 'category'"
51-
assert df.A.cat.categories.empty, "Categories in column A are not empty"
52-
assert (df.B.cat.categories == ["B1", "B2"]).all(), "Categories in column A are not empty"
49+
50+
assert converted.A.dtype == "category", "Dtype in column A is not 'category'"
51+
assert converted.B.dtype == "category", "Dtype in column B is not 'category'"
52+
assert converted.A.cat.categories.empty, "Categories in column A are not empty"
53+
assert converted.B.cat.categories.__contains__(
54+
"B1"
55+
) and converted.B.cat.categories.__contains__(
56+
"B2"
57+
), "Categories in column B doesn't contain adequate categories"
5358

5459
def test_convert_dtypes_retain_column_names(self):
5560
# GH#41435

0 commit comments

Comments
 (0)