REF: Refactor binary operation tests for DataFrame and Series attributes

Author: fbourgey

pandas/tests/frame/test_api.py

@@ -324,15 +324,6 @@ def test_attrs_deepcopy(self):
         assert result.attrs == df.attrs
         assert result.attrs["tags"] is not df.attrs["tags"]
 
-    def test_attrs_binary_operations(self, all_binary_operators):
-        # GH 51607
-        df_1 = DataFrame([1])
-        df_2 = DataFrame([2])
-        attrs = {"info": "DataFrame"}
-        df_1.attrs = attrs
-        assert all_binary_operators(df_1, df_2).attrs == attrs
-        assert all_binary_operators(df_2, df_1).attrs == attrs
-
     @pytest.mark.parametrize("allows_duplicate_labels", [True, False, None])
     def test_set_flags(
         self,

pandas/tests/generic/test_finalize.py

@@ -450,6 +450,22 @@ def test_binops(request, args, annotate, all_binary_operators):
     assert result.attrs == {"a": 1}
 
 
+@pytest.mark.parametrize(
+    "left, right, attrs",
+    [
+        (pd.DataFrame([1]), pd.DataFrame([2]), {"a": 1}),
+        (pd.Series([1]), pd.Series([2]), {"a": 1}),
+        (pd.Series([1]), pd.DataFrame([2]), {"a": 1}),
+        (pd.DataFrame([1]), pd.Series([2]), {"a": 1}),
+    ],
+)
+def test_attrs_binary_operations(all_binary_operators, left, right, attrs):
+    # GH 51607
+    left.attrs = attrs
+    assert all_binary_operators(left, right).attrs == attrs
+    assert all_binary_operators(right, left).attrs == attrs
+
+
 # ----------------------------------------------------------------------------
 # Accessors
 

pandas/tests/series/test_api.py

@@ -160,15 +160,6 @@ def test_attrs(self):
         result = s + 1
         assert result.attrs == {"version": 1}
 
-    def test_attrs_binary_operations(self, all_binary_operators):
-        # GH 51607
-        s1 = Series([1])
-        s2 = Series([2])
-        attrs = {"info": "Series"}
-        s1.attrs = attrs
-        assert all_binary_operators(s1, s2).attrs == attrs
-        assert all_binary_operators(s2, s1).attrs == attrs
-
     def test_inspect_getmembers(self):
         # GH38782
         ser = Series(dtype=object)