Skip to content

Commit ef05ade

Browse files
more type annotations
1 parent 562118e commit ef05ade

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

pandas/core/arrays/arrow/array.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2383,7 +2383,7 @@ def _str_match(
23832383
pat: str,
23842384
case: bool = True,
23852385
flags: int = 0,
2386-
na: Scalar | None = lib.no_default,
2386+
na: Scalar | lib.NoDefault = lib.no_default,
23872387
) -> Self:
23882388
if not pat.startswith("^"):
23892389
pat = f"^{pat}"

pandas/core/arrays/string_arrow.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ def insert(self, loc: int, item) -> ArrowStringArray:
223223

224224
def _predicate_result_converter(self, values, na=lib.no_default):
225225
if self.dtype.na_value is np.nan:
226+
na_value: bool | float | lib.NoDefault
226227
if na is lib.no_default:
227228
na_value = False
228229
elif not isna(na):

pandas/core/strings/base.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
Literal,
77
)
88

9-
import numpy as np
9+
from pandas._libs import lib
1010

1111
if TYPE_CHECKING:
1212
from collections.abc import (
@@ -88,7 +88,11 @@ def _str_repeat(self, repeats: int | Sequence[int]):
8888

8989
@abc.abstractmethod
9090
def _str_match(
91-
self, pat: str, case: bool = True, flags: int = 0, na: Scalar = np.nan
91+
self,
92+
pat: str,
93+
case: bool = True,
94+
flags: int = 0,
95+
na: Scalar | lib.NoDefault = lib.no_default,
9296
):
9397
pass
9498

@@ -98,7 +102,7 @@ def _str_fullmatch(
98102
pat: str | re.Pattern,
99103
case: bool = True,
100104
flags: int = 0,
101-
na: Scalar = np.nan,
105+
na: Scalar | lib.NoDefault = lib.no_default,
102106
):
103107
pass
104108

pandas/core/strings/object_array.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,11 @@ def rep(x, r):
220220
return type(self)._from_sequence(result, dtype=self.dtype)
221221

222222
def _str_match(
223-
self, pat: str, case: bool = True, flags: int = 0, na: Scalar | None = None
223+
self,
224+
pat: str,
225+
case: bool = True,
226+
flags: int = 0,
227+
na: Scalar | lib.NoDefault = lib.no_default,
224228
):
225229
if not case:
226230
flags |= re.IGNORECASE
@@ -235,7 +239,7 @@ def _str_fullmatch(
235239
pat: str | re.Pattern,
236240
case: bool = True,
237241
flags: int = 0,
238-
na: Scalar | None = None,
242+
na: Scalar | lib.NoDefault = lib.no_default,
239243
):
240244
if not case:
241245
flags |= re.IGNORECASE

0 commit comments

Comments
 (0)