Skip to content

Commit f2adc92

Browse files
committed
TST(string dtype): Resolve replace xfails
1 parent 1be2637 commit f2adc92

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

pandas/tests/frame/methods/test_replace.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,6 @@ def test_regex_replace_str_to_numeric(self, mix_abc):
334334
return_value = res3.replace(regex=r"\s*\.\s*", value=0, inplace=True)
335335
assert return_value is None
336336
expec = DataFrame({"a": mix_abc["a"], "b": ["a", "b", 0, 0], "c": mix_abc["c"]})
337-
# TODO(infer_string)
338337
expec["c"] = expec["c"].astype(object)
339338
tm.assert_frame_equal(res, expec)
340339
tm.assert_frame_equal(res2, expec)
@@ -1478,8 +1477,6 @@ def test_replace_regex_dtype_frame(self, regex):
14781477

14791478
df2 = DataFrame({"A": ["0"], "B": ["1"]})
14801479
if regex:
1481-
# TODO(infer_string): both string columns get cast to object,
1482-
# while only needed for column A
14831480
expected_df2 = DataFrame({"A": [1], "B": ["1"]}, dtype=object)
14841481
else:
14851482
expected_df2 = DataFrame({"A": Series([1], dtype=object), "B": ["1"]})

0 commit comments

Comments
 (0)