Skip to content

Commit f30d9b1

Browse files
authored
CI: Clean up some GHAs (#62619)
1 parent a5ac798 commit f30d9b1

File tree

6 files changed

+8
-105
lines changed

6 files changed

+8
-105
lines changed

.github/workflows/broken-linkcheck.yml

Lines changed: 0 additions & 39 deletions
This file was deleted.

.github/workflows/cache-cleanup-daily.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66

77
jobs:
88
cleanup:
9-
runs-on: ubuntu-latest
9+
runs-on: ubuntu-24.04
1010
if: github.repository_owner == 'pandas-dev'
1111
permissions:
1212
actions: write

.github/workflows/cache-cleanup.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ on:
66

77
jobs:
88
cleanup:
9-
runs-on: ubuntu-latest
9+
runs-on: ubuntu-24.04
10+
if: github.repository_owner == 'pandas-dev'
1011
steps:
1112
- name: Clean Cache
1213
run: |

.github/workflows/comment-commands.yml

Lines changed: 0 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -19,64 +19,3 @@ jobs:
1919
with:
2020
previewer-server: "https://pandas.pydata.org/preview"
2121
artifact-job: "Doc Build and Upload"
22-
asv_run:
23-
runs-on: ubuntu-24.04
24-
# TODO: Support more benchmarking options later, against different branches, against self, etc
25-
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '@github-actions benchmark')
26-
defaults:
27-
run:
28-
shell: bash -el {0}
29-
env:
30-
ENV_FILE: environment.yml
31-
COMMENT: ${{github.event.comment.body}}
32-
33-
concurrency:
34-
# Set concurrency to prevent abuse(full runs are ~5.5 hours !!!)
35-
# each user can only run one concurrent benchmark bot at a time
36-
# We don't cancel in progress jobs, but if you want to benchmark multiple PRs, you're gonna have
37-
# to wait
38-
group: ${{ github.actor }}-asv
39-
cancel-in-progress: false
40-
41-
steps:
42-
- name: Checkout
43-
uses: actions/checkout@v5
44-
with:
45-
fetch-depth: 0
46-
47-
# Although asv sets up its own env, deps are still needed
48-
# during discovery process
49-
- name: Set up Conda
50-
uses: ./.github/actions/setup-conda
51-
52-
- name: Run benchmarks
53-
id: bench
54-
continue-on-error: true # asv will exit code 1 for regressions
55-
run: |
56-
# extracting the regex, see https://stackoverflow.com/a/36798723
57-
REGEX=$(echo "$COMMENT" | sed -n "s/^.*-b\s*\(\S*\).*$/\1/p")
58-
cd asv_bench
59-
asv check -E existing
60-
git remote add upstream https://github.com/pandas-dev/pandas.git
61-
git fetch upstream
62-
asv machine --yes
63-
asv continuous -f 1.1 -b $REGEX upstream/main HEAD
64-
echo 'BENCH_OUTPUT<<EOF' >> $GITHUB_ENV
65-
asv compare -f 1.1 upstream/main HEAD >> $GITHUB_ENV
66-
echo 'EOF' >> $GITHUB_ENV
67-
echo "REGEX=$REGEX" >> $GITHUB_ENV
68-
69-
- uses: actions/github-script@v8
70-
env:
71-
BENCH_OUTPUT: ${{env.BENCH_OUTPUT}}
72-
REGEX: ${{env.REGEX}}
73-
with:
74-
script: |
75-
const ENV_VARS = process.env
76-
const run_url = `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`
77-
github.rest.issues.createComment({
78-
issue_number: context.issue.number,
79-
owner: context.repo.owner,
80-
repo: context.repo.repo,
81-
body: '\nBenchmarks completed. View runner logs here.' + run_url + '\nRegex used: '+ 'regex ' + ENV_VARS["REGEX"] + '\n' + ENV_VARS["BENCH_OUTPUT"]
82-
})

.github/workflows/unit-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ jobs:
182182
strategy:
183183
matrix:
184184
# Note: Don't use macOS latest since macos 14 appears to be arm64 only
185-
os: [macos-13, macos-14, windows-latest]
185+
os: [macos-13, macos-14, windows-2025]
186186
env_file: [actions-311.yaml, actions-312.yaml, actions-313.yaml]
187187
fail-fast: false
188188
runs-on: ${{ matrix.os }}
@@ -322,7 +322,7 @@ jobs:
322322
fail-fast: false
323323
matrix:
324324
# Separate out macOS 13 and 14, since macOS 14 is arm64 only
325-
os: [ubuntu-24.04, macOS-13, macOS-14, windows-latest]
325+
os: [ubuntu-24.04, macOS-13, macOS-14, windows-2025]
326326

327327
timeout-minutes: 90
328328

.github/workflows/wheels.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ jobs:
229229
- build_sdist
230230
- build_wheels
231231

232-
runs-on: ubuntu-latest
232+
runs-on: ubuntu-24.04
233233

234234
environment:
235235
name: pypi
@@ -243,6 +243,8 @@ jobs:
243243
with:
244244
path: dist # everything lands in ./dist/**
245245

246+
# TODO: This step can be probably be achieved by actions/download-artifact@v5
247+
# by specifying merge-multiple: true, and a glob pattern
246248
- name: Collect files
247249
run: |
248250
mkdir -p upload

0 commit comments

Comments
 (0)