Skip to content

Commit f9389e1

Browse files
update usage of pa_version_under10p1
1 parent e50fa37 commit f9389e1

File tree

13 files changed

+34
-43
lines changed

13 files changed

+34
-43
lines changed

pandas/_testing/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
set_locale,
1919
)
2020

21-
from pandas.compat import pa_version_under10p1
21+
from pandas.compat import HAS_PYARROW
2222

2323
import pandas as pd
2424
from pandas import (
@@ -183,7 +183,7 @@
183183
]
184184
]
185185

186-
if not pa_version_under10p1:
186+
if HAS_PYARROW:
187187
import pyarrow as pa
188188

189189
UNSIGNED_INT_PYARROW_DTYPES = [pa.uint8(), pa.uint16(), pa.uint32(), pa.uint64()]

pandas/compat/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
from pandas.compat.numpy import is_numpy_dev
2727
from pandas.compat.pyarrow import (
2828
HAS_PYARROW,
29-
pa_version_under10p1,
3029
pa_version_under11p0,
3130
pa_version_under13p0,
3231
pa_version_under14p0,
@@ -160,7 +159,6 @@ def is_ci_environment() -> bool:
160159
"PYPY",
161160
"WASM",
162161
"is_numpy_dev",
163-
"pa_version_under10p1",
164162
"pa_version_under11p0",
165163
"pa_version_under13p0",
166164
"pa_version_under14p0",

pandas/compat/pyarrow.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
import pyarrow as pa
99

1010
_palv = Version(Version(pa.__version__).base_version)
11-
pa_version_under10p1 = _palv < Version("10.0.1")
1211
pa_version_under11p0 = _palv < Version("11.0.0")
13-
pa_version_under12p0 = _palv < Version("12.0.0")
12+
pa_version_under12p1 = _palv < Version("12.0.1")
1413
pa_version_under13p0 = _palv < Version("13.0.0")
1514
pa_version_under14p0 = _palv < Version("14.0.0")
1615
pa_version_under14p1 = _palv < Version("14.0.1")
@@ -22,9 +21,8 @@
2221
pa_version_under20p0 = _palv < Version("20.0.0")
2322
HAS_PYARROW = True
2423
except ImportError:
25-
pa_version_under10p1 = True
2624
pa_version_under11p0 = True
27-
pa_version_under12p0 = True
25+
pa_version_under12p1 = True
2826
pa_version_under13p0 = True
2927
pa_version_under14p0 = True
3028
pa_version_under14p1 = True

pandas/core/arrays/_arrow_string_mixins.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212

1313
from pandas._libs import lib
1414
from pandas.compat import (
15-
pa_version_under10p1,
15+
HAS_PYARROW,
1616
pa_version_under11p0,
1717
pa_version_under13p0,
1818
pa_version_under17p0,
1919
)
2020

21-
if not pa_version_under10p1:
21+
if HAS_PYARROW:
2222
import pyarrow as pa
2323
import pyarrow.compute as pc
2424

pandas/core/arrays/arrow/accessors.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
)
1313

1414
from pandas.compat import (
15-
pa_version_under10p1,
15+
HAS_PYARROW,
1616
pa_version_under11p0,
1717
)
1818

1919
from pandas.core.dtypes.common import is_list_like
2020

21-
if not pa_version_under10p1:
21+
if HAS_PYARROW:
2222
import pyarrow as pa
2323
import pyarrow.compute as pc
2424

@@ -46,7 +46,7 @@ def _is_valid_pyarrow_dtype(self, pyarrow_dtype) -> bool:
4646

4747
def _validate(self, data) -> None:
4848
dtype = data.dtype
49-
if pa_version_under10p1 or not isinstance(dtype, ArrowDtype):
49+
if not HAS_PYARROW or not isinstance(dtype, ArrowDtype):
5050
# Raise AttributeError so that inspect can handle non-struct Series.
5151
raise AttributeError(self._validation_msg.format(dtype=dtype))
5252

pandas/core/arrays/arrow/array.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222
timezones,
2323
)
2424
from pandas.compat import (
25-
pa_version_under10p1,
25+
HAS_PYARROW,
2626
pa_version_under11p0,
27+
pa_version_under12p1,
2728
pa_version_under13p0,
2829
)
2930
from pandas.util._decorators import doc
@@ -74,7 +75,7 @@
7475
from pandas.io._util import _arrow_dtype_mapping
7576
from pandas.tseries.frequencies import to_offset
7677

77-
if not pa_version_under10p1:
78+
if HAS_PYARROW:
7879
import pyarrow as pa
7980
import pyarrow.compute as pc
8081

@@ -300,7 +301,7 @@ class ArrowExtensionArray(
300301
_dtype: ArrowDtype
301302

302303
def __init__(self, values: pa.Array | pa.ChunkedArray) -> None:
303-
if pa_version_under10p1:
304+
if pa_version_under12p1:
304305
msg = "pyarrow>=10.0.1 is required for PyArrow backed ArrowExtensionArray."
305306
raise ImportError(msg)
306307
if isinstance(values, pa.Array):

pandas/core/arrays/string_.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from pandas._libs.lib import ensure_string_array
2626
from pandas.compat import (
2727
HAS_PYARROW,
28-
pa_version_under10p1,
28+
pa_version_under12p1,
2929
)
3030
from pandas.compat.numpy import function as nv
3131
from pandas.util._decorators import (
@@ -182,9 +182,9 @@ def __init__(
182182
raise ValueError(
183183
f"Storage must be 'python' or 'pyarrow'. Got {storage} instead."
184184
)
185-
if storage == "pyarrow" and pa_version_under10p1:
185+
if storage == "pyarrow" and pa_version_under12p1:
186186
raise ImportError(
187-
"pyarrow>=10.0.1 is required for PyArrow backed StringArray."
187+
"pyarrow>=12.0.1 is required for PyArrow backed StringArray."
188188
)
189189

190190
if isinstance(na_value, float) and np.isnan(na_value):

pandas/core/arrays/string_arrow.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
missing as libmissing,
1616
)
1717
from pandas.compat import (
18-
pa_version_under10p1,
18+
HAS_PYARROW,
19+
pa_version_under12p1,
1920
pa_version_under13p0,
2021
pa_version_under16p0,
2122
)
@@ -39,7 +40,7 @@
3940
)
4041
from pandas.core.strings.object_array import ObjectStringArrayMixin
4142

42-
if not pa_version_under10p1:
43+
if HAS_PYARROW:
4344
import pyarrow as pa
4445
import pyarrow.compute as pc
4546

@@ -67,8 +68,8 @@
6768

6869

6970
def _chk_pyarrow_available() -> None:
70-
if pa_version_under10p1:
71-
msg = "pyarrow>=10.0.1 is required for PyArrow backed ArrowExtensionArray."
71+
if pa_version_under12p1:
72+
msg = "pyarrow>=12.0.1 is required for PyArrow backed ArrowExtensionArray."
7273
raise ImportError(msg)
7374

7475

pandas/core/dtypes/dtypes.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@
4646
abbrev_to_npy_unit,
4747
)
4848
from pandas._libs.tslibs.offsets import BDay
49-
from pandas.compat import pa_version_under10p1
49+
from pandas.compat import (
50+
HAS_PYARROW,
51+
pa_version_under12p1,
52+
)
5053
from pandas.errors import PerformanceWarning
5154
from pandas.util._decorators import set_module
5255
from pandas.util._exceptions import find_stack_level
@@ -66,7 +69,7 @@
6669
is_list_like,
6770
)
6871

69-
if not pa_version_under10p1:
72+
if HAS_PYARROW:
7073
import pyarrow as pa
7174

7275
if TYPE_CHECKING:
@@ -2193,8 +2196,8 @@ class ArrowDtype(StorageExtensionDtype):
21932196

21942197
def __init__(self, pyarrow_dtype: pa.DataType) -> None:
21952198
super().__init__("pyarrow")
2196-
if pa_version_under10p1:
2197-
raise ImportError("pyarrow>=10.0.1 is required for ArrowDtype")
2199+
if pa_version_under12p1:
2200+
raise ImportError("pyarrow>=12.0.1 is required for ArrowDtype")
21982201
if not isinstance(pyarrow_dtype, pa.DataType):
21992202
raise ValueError(
22002203
f"pyarrow_dtype ({pyarrow_dtype}) must be an instance "
@@ -2346,7 +2349,7 @@ def construct_from_string(cls, string: str) -> ArrowDtype:
23462349
if string in ("string[pyarrow]", "str[pyarrow]"):
23472350
# Ensure Registry.find skips ArrowDtype to use StringDtype instead
23482351
raise TypeError("string[pyarrow] should be constructed by StringDtype")
2349-
if pa_version_under10p1:
2352+
if pa_version_under12p1:
23502353
raise ImportError("pyarrow>=10.0.1 is required for ArrowDtype")
23512354

23522355
base_type = string[:-9] # get rid of "[pyarrow]"

pandas/tests/arrays/period/test_arrow_compat.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import pytest
22

3-
from pandas.compat.pyarrow import pa_version_under10p1
4-
53
from pandas.core.dtypes.dtypes import PeriodDtype
64

75
import pandas as pd
@@ -33,7 +31,6 @@ def test_arrow_extension_type():
3331
assert hash(p1) != hash(p3)
3432

3533

36-
@pytest.mark.xfail(not pa_version_under10p1, reason="Wrong behavior with pyarrow 10")
3734
@pytest.mark.parametrize(
3835
"data, freq",
3936
[

0 commit comments

Comments
 (0)