fix expected exception in test_arrow.py

Author: jorisvandenbossche

pandas/core/arrays/arrow/array.py

@@ -763,7 +763,7 @@ def _evaluate_op_method(self, other, op, arrow_funcs) -> Self:
                         result = pc.binary_join_element_wise(self._pa_array, other, sep)
                     elif op is roperator.radd:
                         result = pc.binary_join_element_wise(other, self._pa_array, sep)
-                except pa.lib.ArrowNotImplementedError as err:
+                except pa.ArrowNotImplementedError as err:
                     raise TypeError(
                         self._op_method_error_message(other_original, op)
                     ) from err
@@ -804,7 +804,7 @@ def _evaluate_op_method(self, other, op, arrow_funcs) -> Self:
 
         try:
             result = pc_func(self._pa_array, other)
-        except pa.lib.ArrowNotImplementedError as err:
+        except pa.ArrowNotImplementedError as err:
             raise TypeError(self._op_method_error_message(other_original, op)) from err
         return type(self)(result)
 

pandas/tests/extension/test_arrow.py

@@ -944,7 +944,7 @@ def _get_expected_exception(
         self, op_name: str, obj, other
     ) -> type[Exception] | None:
         if op_name in ("__divmod__", "__rdivmod__"):
-            return self.divmod_exc
+            return (self.divmod_exc, TypeError)
 
         dtype = tm.get_dtype(obj)
         # error: Item "dtype[Any]" of "dtype[Any] | ExtensionDtype" has no
@@ -956,7 +956,7 @@ def _get_expected_exception(
             "__mod__",
             "__rmod__",
         }:
-            exc = NotImplementedError
+            exc = (NotImplementedError, TypeError)
         elif arrow_temporal_supported:
             exc = None
         elif op_name in ["__add__", "__radd__"] and (
@@ -971,7 +971,7 @@ def _get_expected_exception(
             # TODO: in many of these cases, e.g. non-duration temporal,
             #  these will *never* be allowed. Would it make more sense to
             #  re-raise as TypeError, more consistent with non-pyarrow cases?
-            exc = pa.ArrowNotImplementedError
+            exc = (pa.ArrowNotImplementedError, TypeError)
         else:
             exc = None
         return exc
@@ -1027,14 +1027,6 @@ def test_arith_series_with_scalar(self, data, all_arithmetic_operators, request)
 
         if all_arithmetic_operators == "__rmod__" and pa.types.is_binary(pa_dtype):
             pytest.skip("Skip testing Python string formatting")
-        elif all_arithmetic_operators in ("__rmul__", "__mul__") and (
-            pa.types.is_binary(pa_dtype) or pa.types.is_string(pa_dtype)
-        ):
-            request.applymarker(
-                pytest.mark.xfail(
-                    raises=TypeError, reason="Can only string multiply by an integer."
-                )
-            )
 
         mark = self._get_arith_xfail_marker(all_arithmetic_operators, pa_dtype)
         if mark is not None:
@@ -1049,14 +1041,6 @@ def test_arith_frame_with_scalar(self, data, all_arithmetic_operators, request):
             pa.types.is_string(pa_dtype) or pa.types.is_binary(pa_dtype)
         ):
             pytest.skip("Skip testing Python string formatting")
-        elif all_arithmetic_operators in ("__rmul__", "__mul__") and (
-            pa.types.is_binary(pa_dtype) or pa.types.is_string(pa_dtype)
-        ):
-            request.applymarker(
-                pytest.mark.xfail(
-                    raises=TypeError, reason="Can only string multiply by an integer."
-                )
-            )
 
         mark = self._get_arith_xfail_marker(all_arithmetic_operators, pa_dtype)
         if mark is not None: