Skip to content

Conversation

EduardAkhmetshin
Copy link
Contributor

This PR fixes docstrings for some methods listed in #59458

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@EduardAkhmetshin
Copy link
Contributor Author

@natmokval I can't edit the reviewers for this PR. Please have a look.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the NaT docstrings as well

@mroeschke mroeschke added the Docs label Aug 12, 2024
@EduardAkhmetshin
Copy link
Contributor Author

You'll need to fix the NaT docstrings as well

Thanks @mroeschke! Fixed.

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants