Skip to content

Conversation

Keramatfar
Copy link

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • [*] Tests added and passed if fixing a bug or adding a new feature
  • [*] All code checks passed.
  • [*] Added type annotations to new arguments/methods/functions.
  • [*] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm negative on returning numeric data as strings. I'm also negative on adding a keyword to this function. I suggest you open up an issue to request this feature and have discussion take place there.

@rhshadrach rhshadrach added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Enhancement labels Nov 19, 2024
@mroeschke
Copy link
Member

Thanks I am also -1 to this enhancement. Closing unless there is an issue opened with positive support for this feature

@mroeschke mroeschke closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants