TST: Added test for pivot_table with int64 dtype and dropna parameter #60374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mroeschke
reviewed
Nov 20, 2024
pandas/tests/reshape/test_pivot.py
Outdated
| result = df.pivot_table( | ||
| index="x", columns="y", values="age", aggfunc="mean", dropna=dropna | ||
| ) | ||
| expected_dtype = "float64" if dtype == "int64" else "Float64" |
There was a problem hiding this comment.
Could you put this in the parametrize instead?
mroeschke
added
the
Testing
mroeschke
approved these changes
Nov 21, 2024
|
Thanks @AbhishekChaudharii |
|
Happy to help! |
KevsterAmp
pushed a commit
to KevsterAmp/pandas
that referenced
this pull request
Mar 12, 2025
…pandas-dev#60374) * added tests for int64 * pre-commit changes * used pytest.mark.parametrize for expected_dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.