Skip to content

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

We no longer support UDFs that mutate the data

https://pandas.pydata.org/pandas-docs/dev/user_guide/gotchas.html#mutating-with-user-defined-function-udf-methods

so I don't think we need to test for this anymore. Plan to move the remaining tests in this file into apply in a followup.

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite Groupby Clean labels Dec 29, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Dec 29, 2024
@mroeschke mroeschke merged commit 37f4392 into pandas-dev:main Dec 29, 2024
57 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the rm_gb_mutation_tests branch December 29, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Groupby Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants