Skip to content

Conversation

arthurlw
Copy link
Member

@arthurlw arthurlw commented Mar 4, 2025

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but I would be -1 on this feature. We recently deprecated accepting JSON-like strings in read_json so this would go against that API consistency.

Additionally the data preprocessing logic here appears straightforward enough to be done by the caller

@arthurlw
Copy link
Member Author

arthurlw commented Mar 5, 2025

Thanks for the review! I was unaware of the deprecation, but I understand the concern about API consistency. Will be closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: json_normalize should work with JSON

2 participants