DOC: Added docstring to Timestamp.tzinfo #61134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 17, 2025
Comment on lines
+2985
to
+2986
| For pandas-specific timezone operations, the `tz` property is the | ||
| recommended interface. |
There was a problem hiding this comment.
This is not necessarily true. Could you remove this statement?
There was a problem hiding this comment.
Thanks for letting me know! I just assumed that tz was preferred because it already had a docstring but tzinfo didn't. I will remove
|
Sorry, it appears a contributor already opened a PR a few days ago to address this issue in #61100 that was merged. Closing this PR as solved, but happy to have more PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #59458
Added docstring to
Timestamp.tzinfo. Emphasized thatTimestamp.tzis preferred due to its Pandas-specific functionality. Sections added are as follows:Removed
Timestamp.tzinfofrom code_checks.shpandas.Timestamp#59458 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.