Fix #60494: query doesn't work on DataFrame integer column names #61207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Mar 31, 2025
pandas/core/frame.py
Outdated
|
|
||
| if any(isinstance(col, int) for col in self.columns): | ||
| self = self.rename( | ||
| columns={col: f"{col}" for col in self.columns if isinstance(col, int)} |
There was a problem hiding this comment.
This should probably be handled in clean_column_name
There was a problem hiding this comment.
But if I handle it in clean_column_name instead of in eval, wouldn't it return the same error since the integer column names would be ignored because of the line [ if not isinstance(k, int) ] in _get_cleaned_column_resolvers, thus not reaching the clean_column_name function. Maybe it can be handled in _get_cleaned_column_resolvers ?
There was a problem hiding this comment.
Maybe the if not isinstance(k, int) needs to be removed in _get_cleaned_column_resolvers instead. I would see what breaks if you remove that.
…ed_column_resolvers Also removed the changes from the previous commit, which converted integer column names to strings
mroeschke
approved these changes
Apr 1, 2025
|
Thanks @David-msggc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1== 0.1") failed with UndefinedVariableError: name 'BACKTICK_QUOTED_STRING_1' is not defined #60494doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Some io code checks failed but they were already failing before the bugfix.
Function _get_cleaned_column_resolvers ignores integer column names, so when it is called on eval function, it returns empty columns which it shouldn't since there is an integer column. Converting the integer columns to strings before calling the _get_cleaned_column_resolvers on eval fucntion fixes this.