-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
DOC: Add documentation for groupby.ewm()
#61283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Returns | ||
| ------- | ||
| pandas.api.typing.ExponentialMovingWindowGroupby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be kept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! Just to clarify, is there a particular reason to prefer pandas.api.typing.ExponentialMovingWindowGroupby over pandas.core.window.ExponentialMovingWindowGroupby?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pandas.core is not a public module
test.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| import pandas as pd | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed
pandas/core/groupby/groupby.py
Outdated
| 4 B 50 | ||
| 5 B 60 | ||
| >>> df.groupby("Class").ewm(com=0.5).mean().reset_index(drop=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the reset_index call?
|
Thanks @arthurlw |
* updated doc and references * precommit * shortened summary * updated according to reviewer suggestions and removed test.py * Fixed docstring error
groupby.ewm()#61268Tests added and passed if fixing a bug or adding a new featureAdded type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.