DOC: Added constructor parameters to DateOffset docstring for API consistency #52431 #61363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainivas-99
commented
Apr 27, 2025
sainivas-99
commented
- Added the constructor signature for DateOffset.
- No functional changes were made, only documentation improvements.
- Part of the issue DOC: Fix docs for various offset constructors #52431 is addressed by this.
|
I'm a bit confused here, as the description of the PR doesn't match the changes. I'll be closing this, as the change here doesn't seem very useful. The issue you refer to is about documenting the parameters of the constructors of the mentioned classes, not adding an example of constructing the class. Also, the examples should go into their section and format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.